chore: migrate resolve and resolve.exports to unrs-resolver

close #15600

Author: JounQin

docs/Configuration.md

@@ -1482,10 +1482,6 @@ type ResolverOptions = {
   moduleDirectory?: Array<string>;
   /** List of `require.paths` to use if nothing is found in `node_modules`. */
   paths?: Array<string>;
-  /** Allows transforming parsed `package.json` contents. */
-  packageFilter?: (pkg: PackageJSON, file: string, dir: string) => PackageJSON;
-  /** Allows transforms a path within a package. */
-  pathFilter?: (pkg: PackageJSON, path: string, relativePath: string) => string;
   /** Current root directory. */
   rootDir?: string;
 };

packages/jest-resolve/package.json

@@ -22,17 +22,13 @@
     "chalk": "^4.0.0",
     "graceful-fs": "^4.2.9",
     "jest-haste-map": "workspace:*",
-    "jest-pnp-resolver": "^1.2.3",
     "jest-util": "workspace:*",
     "jest-validate": "workspace:*",
-    "resolve": "^1.20.0",
-    "resolve.exports": "^2.0.0",
-    "slash": "^3.0.0"
+    "slash": "^3.0.0",
+    "unrs-resolver": "^1.7.8"
   },
   "devDependencies": {
-    "@types/graceful-fs": "^4.1.3",
-    "@types/pnpapi": "^0.0.5",
-    "@types/resolve": "^1.20.2"
+    "@types/graceful-fs": "^4.1.3"
   },
   "engines": {
     "node": "^18.14.0 || ^20.0.0 || >=22.0.0"

packages/jest-resolve/src/__tests__/resolve.test.ts

@@ -6,43 +6,26 @@
  *
  */
 
-import * as path from 'path';
-import {fileURLToPath, pathToFileURL} from 'url';
 import * as fs from 'graceful-fs';
-import {sync as resolveSync} from 'resolve';
 import {type IModuleMap, ModuleMap} from 'jest-haste-map';
+import * as path from 'path';
+import {pathToFileURL} from 'url';
+
 import userResolver from '../__mocks__/userResolver';
 import userResolverAsync from '../__mocks__/userResolverAsync';
-import defaultResolver, {type PackageFilter} from '../defaultResolver';
+import defaultResolver from '../defaultResolver';
 import nodeModulesPaths from '../nodeModulesPaths';
 import Resolver from '../resolver';
 import type {ResolverConfig} from '../types';
 
 jest.mock('../__mocks__/userResolver').mock('../__mocks__/userResolverAsync');
 
-// Do not fully mock `resolve` because it is used by Jest. Doing it will crash
-// in very strange ways. Instead, just spy on it and its `sync` method.
-jest.mock('resolve', () => {
-  const originalModule =
-    jest.requireActual<typeof import('resolve')>('resolve');
-
-  const m = jest.fn<typeof import('resolve')>((...args) =>
-    originalModule(...args),
-  );
-  Object.assign(m, originalModule);
-  m.sync = jest.spyOn(originalModule, 'sync');
-
-  return m;
-});
-
 const mockUserResolver = jest.mocked(userResolver);
 const mockUserResolverAsync = jest.mocked(userResolverAsync);
-const mockResolveSync = jest.mocked(resolveSync);
 
 beforeEach(() => {
   mockUserResolver.mockClear();
   mockUserResolverAsync.async.mockClear();
-  mockResolveSync.mockClear();
 
   Resolver.clearDefaultResolverCache();
 });
@@ -134,25 +117,6 @@ describe('findNodeModule', () => {
     });
   });
 
-  it('wraps passed packageFilter to the resolve module when using the default resolver', () => {
-    const packageFilter = jest.fn<PackageFilter>();
-
-    // A resolver that delegates to defaultResolver with a packageFilter implementation
-    mockUserResolver.mockImplementation((request, opts) =>
-      opts.defaultResolver(request, {...opts, packageFilter}),
-    );
-
-    Resolver.findNodeModule('./test', {
-      basedir: path.resolve(__dirname, '../__mocks__/'),
-      resolver: require.resolve('../__mocks__/userResolver'),
-    });
-
-    expect(packageFilter).toHaveBeenCalledWith(
-      expect.objectContaining({name: '__mocks__'}),
-      expect.any(String),
-    );
-  });
-
   it('supports file URLs', () => {
     const path = pathToFileURL(__filename).href;
     const newPath = Resolver.findNodeModule(path, {
@@ -209,7 +173,7 @@ describe('findNodeModule', () => {
       );
     });
 
-    test('respects order in package.json, not conditions', () => {
+    test('respects order in conditions over package.json', () => {
       const resultImport = Resolver.findNodeModule('exports', {
         basedir: conditionsRoot,
         conditions: ['import', 'require'],
@@ -219,7 +183,7 @@ describe('findNodeModule', () => {
         conditions: ['require', 'import'],
       });
 
-      expect(resultImport).toEqual(resultRequire);
+      expect(resultImport).not.toEqual(resultRequire);
     });
 
     test('supports nested paths', () => {
@@ -407,7 +371,9 @@ describe('findNodeModule', () => {
           basedir: path.resolve(importsRoot, './foo-import/index.js'),
           conditions: [],
         });
-      }).toThrow('Missing "#something-else" specifier in "foo-import" package');
+      }).toThrow(
+        `Package import specifier "#something-else" is not defined in package ${path.join(importsRoot, 'foo-import/package.json')}`,
+      );
     });
   });
 });
@@ -446,27 +412,6 @@ describe('findNodeModuleAsync', () => {
     });
   });
 
-  it('passes packageFilter to the resolve module when using the default resolver', async () => {
-    const packageFilter = jest.fn<PackageFilter>();
-
-    // A resolver that delegates to defaultResolver with a packageFilter implementation
-    mockUserResolverAsync.async.mockImplementation((request, opts) =>
-      Promise.resolve(opts.defaultResolver(request, {...opts, packageFilter})),
-    );
-
-    await Resolver.findNodeModuleAsync('test', {
-      basedir: '/',
-      resolver: require.resolve('../__mocks__/userResolverAsync'),
-    });
-
-    expect(mockResolveSync).toHaveBeenCalledWith(
-      'test',
-      expect.objectContaining({
-        packageFilter,
-      }),
-    );
-  });
-
   it('supports file URLs', async () => {
     const path = pathToFileURL(__filename).href;
     const newPath = await Resolver.findNodeModuleAsync(path, {