Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @typescript-eslint to v3 #10177

Closed
SimenB opened this issue Jun 19, 2020 · 8 comments
Closed

Update @typescript-eslint to v3 #10177

SimenB opened this issue Jun 19, 2020 · 8 comments

Comments

@SimenB
Copy link
Member

SimenB commented Jun 19, 2020

If possible without extra peer dep warnings, updating to eslint@7 would be nice as well

@SimenB
Copy link
Member Author

SimenB commented Jun 19, 2020

@G-Rath seems I'm unable to actually assign you, so consider this message that 😀

@G-Rath
Copy link
Contributor

G-Rath commented Jun 21, 2020

@SimenB I did the upgrade to run lint against the codebase quickly to just get a sense of how much work would be involved, and right now the big one is the adding of Function to the defaults for ban-types.

I'm happy to go through them and have a go at replacing them with a stricter type, but if you could keep an eye out for usage of that type in PRs and ask authors to use a stricter type that would save me some work :)

(I don't expect there to be many, but did notice #10073, which I've put a comment on).

@SimenB
Copy link
Member Author

SimenB commented Jun 23, 2020

Happy to take a PR adding Function to ban-types without the whole upgrade to v3. Might help landing this a bit iteratively if it's gonna be a big PR?

@G-Rath
Copy link
Contributor

G-Rath commented Jun 23, 2020

Totally! Landing iteratively is the way to go - I'll probably go package by package at this point, as there's quite a few uses of Function 😅

@SimenB
Copy link
Member Author

SimenB commented Aug 21, 2020

@G-Rath now that TS 4 is out (and I'd love to use labeled tuples), any idea how close we are to being able to upgrade?

@G-Rath
Copy link
Contributor

G-Rath commented Aug 22, 2020

@SimenB getting there slowly :/

@SimenB
Copy link
Member Author

SimenB commented Dec 11, 2020

I'd say this is done via #10437

@SimenB SimenB closed this as completed Dec 11, 2020
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants