[jest-worker] change engines.node on ^10.13.0 for jest-worker

[alexander-akait]

💬 Questions and Help

We use jest-worker in many plugins for webpack (for example https://www.npmjs.com/package/terser-webpack-plugin have around 19-20kk downloads per week), and we have a minimal version Node.js support ^10.13.0 (LTS), recently released jest v27 (here I say about jest-worker v27) has many good fixes and we would like to update, unfortunately we cannot do this because the change of engines.node is breaking change. I totally agree that supporting only LTS version is good idea and I fully understand why this was done. Unfortunately many developers still run tests on CI using non LTS Node.js versions and we would like to avoid extra breaking changes.

If you can make an exception for jest-worker and change engines.node on >10.13.0, I would be very happy, it will save a lot of time for us and for other developers. We have already planned to use the same support in engines.node (i.e. only LTS), so in the future I think we won't have such problems anymore.

Big thanks!

/cc @SimenB

[ludofischer]

It looks like it's already ^10.23. I've just updated it in cssnano too...

https://github.com/facebook/jest/blob/50216cd49bd4365bd9b4afcaf328f8273ca2c612/packages/jest-worker/package.json#L29

[alexander-akait]

"node": "^10.13.0 || ^12.13.0 || ^14.15.0 || >=15.0.0"

engines.node on >10.13.0

It will not allow to using 11/13 Node.js

[SimenB]

https://github.com/facebook/jest/blob/50216cd49bd4365bd9b4afcaf328f8273ca2c612/packages/jest-worker/package.json#L28-L30

It's already 10.13? We'll be dropping v10 and v15 for jest 28, but this seems correct now?

Or do you mean that v11 and v13 is excluded from the current matrix?

[alexander-akait]

@SimenB

Or do you mean that v11 and v13 is excluded from the current matrix?

Yes, just set "node": ">= 10.13.0"

[SimenB]

hah, a bunch of comments at once 😀 OK, so your range is >=10.13.0 essentially?

[SimenB]

It'd be sorta misleading as we don't test on those versions on CI. Presumably it'd work fine, though

[alexander-akait]

Yep, example https://github.com/webpack-contrib/terser-webpack-plugin/blob/master/package.json#L16 https://github.com/webpack/webpack/blob/master/package.json#L108 and for other plugins we use the same

[SimenB]

Gotcha. You should probably be more precise to avoid so many EOL versions, but I agree changing it is a breaking change 👍

But sure, can probably loosen the requirement in jest-worker, but I don't wanna change any other place (so if e.g. webpack itself wants to upgrade to jest 27 they'll still get engine warnings)

[alexander-akait]

I think that this does not create problems for jest itself and for jest-worker package if anybody will have strange errors due Node.js internal problems we will just say - "Please use LTS Node.js versions, non LTS version is not stable"

[alexander-akait]

But sure, can probably loosen the requirement in jest-worker, but I don't wanna change any other place (so if e.g. webpack itself wants to upgrade to jest 27 they'll still get engine warnings)

It is fine, we strongly say only LTS version are stable and please use them. And yes only for jest-worker.

[alexander-akait]

No problems with dependencies of jest-worker due https://github.com/grncdr/merge-stream/blob/master/package.json and https://github.com/chalk/supports-color/blob/main/package.json#L19

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.