Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]: Add jest-environment-jsdom information to guides for dom manipulation #12828

Closed
Aveline-art opened this issue May 10, 2022 · 2 comments · Fixed by #12831
Closed

[Docs]: Add jest-environment-jsdom information to guides for dom manipulation #12828

Aveline-art opened this issue May 10, 2022 · 2 comments · Fixed by #12831

Comments

@Aveline-art
Copy link
Contributor

🚀 Feature Proposal

Nothing too huge. While trying to integrate JSDom with Jest (for use with React Testing Lib), I could not for the life of me figure out what was missing until I dug into the change logs (https://jestjs.io/blog/2022/04/25/jest-28#breaking-changes). Just a quick addition to this documentation clarifying the need to both manually add jest-environment-jsdom and setting the environment to jsdom would help in setting up jest quickly for dom testing.

Motivation

Makes your docs easier to use and understand so that developers would not need to dig into change logs to find answers.

Example

No response

Pitch

This is a quick and easy way to improve documentation so that users can get started on testing a lot quicker.

@mrazauskas
Copy link
Contributor

Good idea. Just send a PR. By the way, pointing to test environment docs (like here) could be useful too.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants