testing with the library "gl" (aka headless-gl) breaks if you have more than one test file #2029

gre · 2016-10-31T13:09:35Z

What is the current behavior?

I have written 2 identical tests.

Each test individually passes.
Putting the 2 tests in a same file, passes.
but if each test is put in 2 files. it breaks.

Repository that reproduce the bug:

https://github.com/gre/jest-multi-tests-gl-issue

What is the expected behavior?

The tests should pass. (it passes in a same file!)

--debug

jest version = 16.0.2
test framework = jasmine2
config = {
  "rootDir": "/Users/gre/Desktop/jest-multi-tests-gl-issue",
  "name": "-Users-gre-Desktop-jest-multi-tests-gl-issue",
  "setupFiles": [],
  "testRunner": "/Users/gre/Desktop/jest-multi-tests-gl-issue/node_modules/jest-jasmine2/build/index.js",
  "scriptPreprocessor": "/Users/gre/Desktop/jest-multi-tests-gl-issue/node_modules/babel-jest/build/index.js",
  "usesBabelJest": true,
  "automock": false,
  "bail": false,
  "browser": false,
  "cacheDirectory": "/var/folders/3q/zjl78zks3bv7_8lfw8r505x40000gn/T/jest",
  "clearMocks": false,
  "coveragePathIgnorePatterns": [
    "/node_modules/"
  ],
  "coverageReporters": [
    "json",
    "text",
    "lcov",
    "clover"
  ],
  "globals": {},
  "haste": {
    "providesModuleNodeModules": []
  },
  "mocksPattern": "__mocks__",
  "moduleDirectories": [
    "node_modules"
  ],
  "moduleFileExtensions": [
    "js",
    "json",
    "jsx",
    "node"
  ],
  "moduleNameMapper": {},
  "modulePathIgnorePatterns": [],
  "noStackTrace": false,
  "notify": false,
  "preset": null,
  "preprocessorIgnorePatterns": [
    "/node_modules/"
  ],
  "resetModules": false,
  "testEnvironment": "jest-environment-jsdom",
  "testPathDirs": [
    "/Users/gre/Desktop/jest-multi-tests-gl-issue"
  ],
  "testPathIgnorePatterns": [
    "/node_modules/"
  ],
  "testRegex": "(/__tests__/.*|\\.(test|spec))\\.jsx?$",
  "testURL": "about:blank",
  "timers": "real",
  "useStderr": false,
  "verbose": null,
  "watch": false,
  "cache": true,
  "watchman": true,
  "testcheckOptions": {
    "times": 100,
    "maxSize": 200
  }
}
 PASS  ./b.test.js
 FAIL  ./a.test.js
  ● foo

    TypeError: framebufferTexture2D(GLenum, GLenum, GLenum, WebGLTexture, GLint)

      at WebGLRenderingContext.framebufferTexture2D (node_modules/gl/webgl.js:2297:11)
      at Object.<anonymous>.test (a.test.js:4:12)
      at process._tickCallback (internal/process/next_tick.js:103:7)

Test Suites: 1 failed, 1 passed, 2 total
Tests:       1 failed, 1 passed, 2 total
Snapshots:   0 total
Time:        1.435s
Ran all test suites.

The text was updated successfully, but these errors were encountered:

thymikee · 2016-12-08T22:32:20Z

Confirmed, this is really strange. Maybe gl has some issues with running under Node's vm?

thymikee · 2016-12-08T22:33:59Z

Although it's most probably not Jest-related (but not 100% sure, maybe we run on some edge case here). So for now I'll close the issue but happy to keep the discussion going and reopen if necessary.

cpojer · 2016-12-12T11:00:27Z

Does it work with two files when doing jest -i? We parallelize across processes, so that may be an issue here?

thymikee · 2016-12-12T11:01:56Z

Tested with -i, fails too.

cpojer · 2016-12-12T11:03:00Z

That's really odd then because that makes it run in process, serially. It may indeed be a gl issue in this case.

mcrawshaw · 2017-03-08T22:38:20Z

Not sure this will have any impact, but maybe try destroying the gl context at the end of each test (plus the -i arg)...

gl.getExtension('STACKGL_destroy_context').destroy()

gre · 2017-03-09T09:00:37Z

I'm pretty sure my tests aren't leaking a gl context (I mean, at least in my "real" tests, not the one I showcase. but yeah, I can try to add that, i'm pretty sure it won't change)

gre · 2017-03-09T09:08:06Z

I've updated the showcase with the destroy() and also the latest jest version. the bug still occurs. -i does not help neither.

even tho the tests are identically, only one pass. and a test file that contains twice the test still pass. this does not make sense.

mcrawshaw · 2017-03-09T09:15:09Z

Yeah, I worked on it all morning... It is bizarre...

I can't run the test a second time within the same Jest process instance. If I quit the jest process and start again its ok.

As you mentioned, destroying contexts doesn't help, you can actually create many, many contexts in a loop without issue.

At the moment it's working because I changed the function that tests for the type error. It's situated in node_modules/gl/webgl.js.

function checkObject (object) {
  return typeof object === 'object' ||
  !object
}

All I have done is loosen the void check from object === void 0 to !object. Now it runs, at least it can create a gl context.

More work to do tomorrow.

pconerly · 2017-03-15T17:49:11Z

@mcrawshaw I made that change and my yarn tests were able to run successfully multiple times. We're not doing anything more than creating the GL context in our tests, but they were able to run multiple times.

quasor · 2017-04-06T00:46:06Z

@thymikee given the above efforts, shall we reopen this?

thymikee · 2017-04-06T06:06:12Z

Let's keep this open until we find proper solution or fix the gl lib.

thymikee · 2017-05-11T16:46:39Z

Closing due to: #3552 (as a workaround use --no-cache flag for now)

gre · 2017-05-11T16:49:07Z

interesting! thanks

ghost · 2017-07-31T14:32:43Z

Hey, @mikolalysenko @mourner
Any chance you could propagate @mcrawshaw 's fix into gl so it doesn't happen again ?
Or confirm why the void check has to be so strict ?
Thanks guys :)

mourner · 2017-08-01T16:40:33Z

@alvinsight I'm not sure about that check, but I'd welcome a PR!

mcrawshaw · 2017-08-02T13:52:27Z

I'm not sure on the fix I mentioned above, it was something I came too after tracing the code. When I apply the fix and run it now I receive this error: THREE.WebGLShader: Shader couldn't compile.. Also, it doesn't make any sense why it works.

@gre your repo works when --no-cache is added to the args. I also don't see how this would impact the result. It's just a transpilation cache, there must be more too it.

I think we need to understand just what is going on with the --no-cache flag to work out the best approach to the problem.

ghost · 2017-08-02T15:07:23Z

Ah, dang, good luck @mcrawshaw !
it's weird that THREE.WebGLShader even appears there, are you using three.js ?
three.js is weird so I wouldn't use it, all my test cases work as long as I add --no-cache and they're pretty similar to @gre 's repo.
Good luck again!

hujiulong · 2018-04-12T09:22:06Z

@mcrawshaw @mourner @gre

I found the reason, but I don't know how to fix it. I'm not sure this is the bug of gl or jest.

In gl/webgl.js, there is such a piece of code:

var gl = nativeGL.WebGLRenderingContext.prototype
// ...
var _framebufferTexture2D = gl.framebufferTexture2D    // native function
gl.framebufferTexture2D = function framebufferTexture2D(
    target,
    attachment,
    textarget,
    texture,
    level ) {
    // ...
    if ( !checkObject( texture ) ) {
        throw new TypeError( 'framebufferTexture2D(GLenum, GLenum, GLenum, WebGLTexture, GLint)' )
    }
    // ...
}

In another place in gl/webgl.js, there is such a piece of code:

// line 
for ( var i = 0; i < ATTACHMENTS.length; ++i ) {
    _framebufferTexture2D.call(
        context,
        gl.FRAMEBUFFER,
        ATTACHMENTS[ i ],
        gl.TEXTURE_2D,
        0,    //  -> as parameter `texture`
        0 )
}

under normal circumstances, _framebufferTexture2D.call should be executed the native function, however, when running with jest, it is possible to call the overridden method(the js function)

checkObject( texture ) -> checkObject( 0 );

function checkObjectA (object) {
  return typeof object === 'object' ||
  !object
}
function checkObjectB (object) {
  return typeof object === 'object' ||
  (object === void 0)
}

checkObjectA( 0 );  // true
checkObjectB( 0 );  // false

robertleeplummerjr · 2019-09-02T01:15:42Z

I believe I know what the issue is, it is that how the library is being instantiated. There are a lot of jit overriding happening and privatizing of the native methods. The refactor I'm working on here: stackgl/headless-gl#166 should resolve it as it no longer overwrites the methods, but just properly calls them using super.method() when overloading.

github-actions · 2021-05-11T19:08:57Z

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

thymikee added Confirmed Help Wanted labels Dec 8, 2016

thymikee closed this as completed Dec 8, 2016

gre mentioned this issue Dec 9, 2016

issue with running the library in parallel stackgl/headless-gl#91

Open

thymikee reopened this Apr 6, 2017

This was referenced May 11, 2017

Error when nodegit is referenced from several places #3550

Closed

Jest transform cache breaks tests using native code #3552

Closed

thymikee closed this as completed May 11, 2017

swistak35 mentioned this issue Apr 4, 2019

Failure when using in more than one jest suite gpujs/gpu.js#449

Closed

github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

testing with the library "gl" (aka headless-gl) breaks if you have more than one test file #2029

testing with the library "gl" (aka headless-gl) breaks if you have more than one test file #2029

gre commented Oct 31, 2016

thymikee commented Dec 8, 2016

thymikee commented Dec 8, 2016

cpojer commented Dec 12, 2016

thymikee commented Dec 12, 2016

cpojer commented Dec 12, 2016

mcrawshaw commented Mar 8, 2017

gre commented Mar 9, 2017

gre commented Mar 9, 2017

mcrawshaw commented Mar 9, 2017 •

edited

Loading

pconerly commented Mar 15, 2017

quasor commented Apr 6, 2017 •

edited

Loading

thymikee commented Apr 6, 2017 •

edited

Loading

thymikee commented May 11, 2017

gre commented May 11, 2017

ghost commented Jul 31, 2017

mourner commented Aug 1, 2017

mcrawshaw commented Aug 2, 2017

ghost commented Aug 2, 2017

hujiulong commented Apr 12, 2018 •

edited

Loading

robertleeplummerjr commented Sep 2, 2019

github-actions bot commented May 11, 2021

testing with the library "gl" (aka headless-gl) breaks if you have more than one test file #2029

testing with the library "gl" (aka headless-gl) breaks if you have more than one test file #2029

Comments

gre commented Oct 31, 2016

thymikee commented Dec 8, 2016

thymikee commented Dec 8, 2016

cpojer commented Dec 12, 2016

thymikee commented Dec 12, 2016

cpojer commented Dec 12, 2016

mcrawshaw commented Mar 8, 2017

gre commented Mar 9, 2017

gre commented Mar 9, 2017

mcrawshaw commented Mar 9, 2017 • edited Loading

pconerly commented Mar 15, 2017

quasor commented Apr 6, 2017 • edited Loading

thymikee commented Apr 6, 2017 • edited Loading

thymikee commented May 11, 2017

gre commented May 11, 2017

ghost commented Jul 31, 2017

mourner commented Aug 1, 2017

mcrawshaw commented Aug 2, 2017

ghost commented Aug 2, 2017

hujiulong commented Apr 12, 2018 • edited Loading

robertleeplummerjr commented Sep 2, 2019

github-actions bot commented May 11, 2021

mcrawshaw commented Mar 9, 2017 •

edited

Loading

quasor commented Apr 6, 2017 •

edited

Loading

thymikee commented Apr 6, 2017 •

edited

Loading

hujiulong commented Apr 12, 2018 •

edited

Loading