-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Include obsolete snapshots info in json output #2044
Comments
Hmm, I'm also having trouble with obsolete. I see |
I was hoping we could change Jest so that it actually fails the test itself when something is obsolete. |
Yeah, no way to understand what's wrong (example — https://circleci.com/gh/electron-userland/electron-builder/447?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link) It seems Jest doesn't detect that actually test is just skipped/ignored. |
@develar do you think you could help with a PR? This data could be added here: https://github.com/cpojer/jest/blob/e4220e6659abdc4d6d4500455eb4982d3230dba3/packages/jest-jasmine2/src/index.js#L97 and we could add the |
Having the same issue with our project build on Jenkins, though on local dev env everything is ok. |
this error is really annyoing |
@adaniliuk I saw this error today but in my case it was because my build process was copying the |
Obsolete snapshots are reproted as "unchecked" in JSON output. Also, the snapshot summary was recently overhauled by @rickhanlonii #6181, will be available in Jest 23 :) |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Do you want to request a feature or report a bug?
Feature
What is the current behavior?
If one wants to check if there are any obsolete snapshots, one must parse the human readable command output.
What is the expected behavior?
I reckon the info should be included in the
--json
output.Also it might make sense if there was a switch that made the existence of obsolete snapshots cause jest to exit with an error. The use case I personally see is having a git hook to prevent me from accidentally committing obsolete snapshots.
The text was updated successfully, but these errors were encountered: