restoreMocks doesn't reset the mocks from the last test if mocking jsdom in a beforeEach

[lukeapage]

Do you want to request a feature or report a bug?

Bug

What is the current behavior?

https://repl.it/@lukeapage/Fails-based-on-order

In the above repl you need to make sure the tests run the files in the right order - one then two. When two fails it goes to the begining, the tests pass and then its difficult to reproduce.

If in one test file you mock jsdom in a beforeEach and in a second file use the jsdom function unmocked, then you end up with the mock function.

I tried to make a test case not using jsdom and it was fine.

Within one file its fine.

If the last test in a file doesn't have a beforeEach adding the mock, its also fine.

e.g. the restoreMocks option is behaving differently to adding jest.restoreAllMocks() in a afterEach

What is the expected behavior?

restoreMocks: true will restore all mocks

Please provide your exact Jest configuration
Run npx envinfo --preset jest in your project directory and paste the
results here

See the repl above

[lukeapage]

Is the cause that restoreAllMocks is called in a global beforeEach rather than afterEach and jsdom survives between test files?

[lukeapage]

I moved it to a afterEach in my own project (where we have 900 suites and random failures) and it seems fine. But I don't know why its in beforeEach so I'll wait to hear from someone before I send a patch.

[github-actions]

This issue is stale because it has been open for 1 year with no activity. Remove stale label or comment or this will be closed in 30 days.

[github-actions]

This issue was closed because it has been stalled for 7 days with no activity. Please open a new issue if the issue is still relevant, linking to this one.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.