Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the diff between expected/received on mock calls #5843

Closed
gustavovnicius opened this issue Mar 21, 2018 · 3 comments
Closed

Improve the diff between expected/received on mock calls #5843

gustavovnicius opened this issue Mar 21, 2018 · 3 comments
Labels
good first issue Help Wanted 🚀 Enhancement

Comments

@gustavovnicius
Copy link
Contributor

gustavovnicius commented Mar 21, 2018 •
edited
Loading

The diff output of a mismatched spy/mock argument is not nice. It'd be good to make it look similar to how a "normal" diff (like when using .toBe) looks.

Here is a ridiculous example, trying to stress out the difference:
https://repl.it/@gustavovnicius/jest-diff

Saving you a click:

image
Nice diff

image
Nasty diff
@SimenB
Copy link
Member

SimenB commented Mar 21, 2018

Printing a comparison using the same mechanism sounds good to me. PR welcome!

@gustavovnicius gustavovnicius mentioned this issue Mar 21, 2018
Merged
@gustavovnicius
Copy link
Contributor Author

gustavovnicius commented Mar 21, 2018 •
edited
Loading

@SimenB #5846 ☝️😄

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Help Wanted 🚀 Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SimenB @gustavovnicius