Incorrect transform for multiple projects with different transform in the same process #5855

amosyuen · 2018-03-22T05:45:43Z

Do you want to request a feature or report a bug?
Report a bug

What is the current behavior?
Jest uses the same transform for projects with different transform behavior if they run in the same process.

If the current behavior is a bug, please provide the steps to reproduce and
either a repl.it demo through https://repl.it/languages/jest or a minimal
repository on GitHub that we can yarn install and yarn test.

Repository https://github.com/amosyuen/jest-projects-transform-error.
Running yarn test succeeds. But running yarn test --runInBand will fail. Error message indicates that the incorrect babel transform was used.

What is the expected behavior?
Correct transform for the project should be used. Both yarn test and yarn test --runInBand should succeed.

Please provide your exact Jest configuration
https://github.com/amosyuen/jest-projects-transform-error/blob/master/jest.config.js

Run npx envinfo --preset jest in your project directory and paste the
results here

Environment:
OS: Windows 10
Node: 8.9.4
Yarn: 1.5.1
npm: 5.6.0
Watchman: Not Found
Xcode: N/A
Android Studio: Version 3.0.0.0 AI-171.4443003

The text was updated successfully, but these errors were encountered:

thymikee · 2018-05-25T16:10:03Z

The issue with your configuration is using custom transformer, which is not fully functional (e.g. doesn't have getCacheKey implemented) – that's probably why you have issues with mixing cache.

You should rather stick with default transformer and use moduleNameMapper to alias react-native to react-native-web:

const os = require("os");
const path = require("path");

const nativeConfig = {
  displayName: "native",
  preset: "jest-expo",
  testMatch: ['**/*.test.native.js']
};
const webConfig = {
  displayName: "web",
  moduleNameMapper: {
    "react-native": "react-native-web"
  },
  setupFiles: ["jest-canvas-mock"],
  testMatch: ['**/*.test.web.js']
};

module.exports = {
  projects: [nativeConfig, webConfig]
};

amosyuen · 2018-05-29T01:01:05Z

That simple example doesn't quite represent our real transformers, there's many other differences between the transformers for our web and native config besides just module mapping, it's not possible to do them using a default transformer and other options.

amosyuen · 2018-05-29T02:01:24Z

I tried modifying the cache key, and the problem persists. Is this the right way? amosyuen/jest-projects-transform-error@e75baeb

amosyuen · 2018-05-29T02:05:35Z

As far as I can tell, modifying the getCacheKey() function doesn't affect this problem. I even tried setting the cache key to a large random string, same problem.

I think the problem is that the transformer is being cached between tests which require a different transformer.

amosyuen · 2018-05-29T02:06:16Z

Pleas re-open until it's actually solved.

viknes-interana · 2018-12-28T18:25:46Z

I can confirm this issue still occurs. I have a similar use case where I have 2 projects - one that runs just unit tests and another that runs e2e screenshot tests (uses jest-image-snapshot) and I want to mock out scss files when my unit tests are run but use a custom transformer for scss files when e2e screenshot tests are run. When there are a large number of tests, the transformed result of 1 project gets used in the other project even though they both have different cache keys.
unit.test.config.js

moduleNameMapper: {
    '\\.(css|scss)$': 'identity-obj-proxy',
},
transform: {
    '\\.jsx?$': 'babel-jest',
},

screenshot.test.config.js

moduleNameMapper: {
    '\\.css$': 'identity-obj-proxy',
},
transform: {
    '\\.scss$': '<rootDir>/jest/scssTransformer.js',
    '\\.jsx?$': 'babel-jest',
},

SimenB · 2018-12-29T20:24:51Z

This should be fixed in #7186, can you install jest@beta (currently resolving to jest@24.0.0-alpha.9) and see if the issue is fixed?

viknes-interana · 2018-12-30T01:17:48Z

I tried upgrading to the beta package. But I ran in to some other issues before I can even get to testing this specific bug.
First error I got was

TypeError: Cannot read property 'concat' of undefined
    at Object.<anonymous> (/myproject/node_modules/jest-resolve/build/isBuiltinModule.js:29:27)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/myproject/node_modules/jest-resolve/build/index.js:25:47)
    at Module._compile (module.js:570:32)

which I got past with a temporary hack (adding a (foo || []) in front of the .concat by manually editing the troubled node_modules file.
But then I ran in to this when I tried to run my tests

Plugin/Preset files are not allowed to export objects, only functions. In /myproject/node_modules/babel-preset-react/lib/index.js

      at createDescriptor (node_modules/@babel/core/lib/config/config-descriptors.js:178:11)
      at items.map (node_modules/@babel/core/lib/config/config-descriptors.js:109:50)
      at Array.map (native)
      at createDescriptors (node_modules/@babel/core/lib/config/config-descriptors.js:109:29)
      at createPresetDescriptors (node_modules/@babel/core/lib/config/config-descriptors.js:101:10)
      at presets (node_modules/@babel/core/lib/config/config-descriptors.js:47:19)
      at mergeChainOpts (node_modules/@babel/core/lib/config/config-chain.js:320:26)
      at node_modules/@babel/core/lib/config/config-chain.js:283:7
      at buildRootChain (node_modules/@babel/core/lib/config/config-chain.js:120:22)
      at loadPrivatePartialConfig (node_modules/@babel/core/lib/config/partial.js:85:55)

I am on babel@6.26.0 but seems like it is expecting babel 7? I am not sure. I tried upgrading to babel 7 but there are some incompatible packages that needed upgrading as well. If I ever upgrade to babel 7, I will test it out and let you know. In the meantime, the approach in the linked ticket seems promising and I'm confident it will fix this bug. Thank you for looking in to this!

SimenB · 2018-12-30T08:37:50Z

Yes, the new version of Jest requires Babel 7.

The first error is an unintended breaking change from #7408, wanna send a PR to fix it?

necolas · 2018-12-30T18:22:09Z

I'm also seeing TypeError: Cannot read property 'concat' of undefined. I installed the beta to resolve various issues I encountered while upgrading to Babel 7. It seemed to be working last week, but when I ran a fresh yarn install it started breaking; perhaps yarn resolved a different dependency tree.

SimenB · 2018-12-30T18:44:57Z

Yeah, the concat bug is pretty bad, I'll put up a PR.

It'll work in node 9, 10 and 11, you probably ran one of those?

necolas · 2018-12-30T18:46:29Z

I found the reason for the TypeError in my case: running an older version of Node.js 8.

When I upgraded eslint it failed to install and printed this error:

error eslint@5.11.1: The engine "node" is incompatible with this module. Expected version "^6.14.0 || ^8.10.0 || >=9.10.0".
error Found incompatible module
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.

After upgrading Node.js, Jest started running without errors too. You may want to update the engines field in your package.json files to match the last version of Node.js that can run the jest beta.

SimenB · 2018-12-30T18:51:14Z

Added in 6.13 and 8.10, actually.

https://nodejs.org/docs/latest-v6.x/api/modules.html#modules_module_builtinmodules
https://nodejs.org/docs/latest-v8.x/api/modules.html#modules_module_builtinmodules

SimenB · 2018-12-30T18:58:17Z

PR: #7565

thymikee · 2019-01-07T12:06:57Z

Closing as #7565 is merged now (and hopefully fixes the problem, please let us know).

SimenB · 2019-01-07T12:44:11Z

Closed by #7186 really, #7565 just fixed a regression introduced for older nodes in #7408

github-actions · 2021-05-12T06:06:34Z

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

thymikee added the Needs Triage label Mar 24, 2018

thymikee closed this as completed May 25, 2018

thymikee reopened this May 29, 2018

SimenB mentioned this issue Dec 30, 2018

fix: handle builtinModules missing #7565

Merged

thymikee closed this as completed Jan 7, 2019

SimenB mentioned this issue Jan 23, 2019

update deprecated process.binding() call #7682

Closed

github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Incorrect transform for multiple projects with different transform in the same process #5855

Incorrect transform for multiple projects with different transform in the same process #5855

amosyuen commented Mar 22, 2018 •

edited

Loading

thymikee commented May 25, 2018

amosyuen commented May 29, 2018

amosyuen commented May 29, 2018

amosyuen commented May 29, 2018

amosyuen commented May 29, 2018

viknes-interana commented Dec 28, 2018

SimenB commented Dec 29, 2018

viknes-interana commented Dec 30, 2018 •

edited

Loading

SimenB commented Dec 30, 2018

necolas commented Dec 30, 2018

SimenB commented Dec 30, 2018

necolas commented Dec 30, 2018

SimenB commented Dec 30, 2018

SimenB commented Dec 30, 2018

thymikee commented Jan 7, 2019

SimenB commented Jan 7, 2019

github-actions bot commented May 12, 2021

Incorrect transform for multiple projects with different transform in the same process #5855

Incorrect transform for multiple projects with different transform in the same process #5855

Comments

amosyuen commented Mar 22, 2018 • edited Loading

thymikee commented May 25, 2018

amosyuen commented May 29, 2018

amosyuen commented May 29, 2018

amosyuen commented May 29, 2018

amosyuen commented May 29, 2018

viknes-interana commented Dec 28, 2018

SimenB commented Dec 29, 2018

viknes-interana commented Dec 30, 2018 • edited Loading

SimenB commented Dec 30, 2018

necolas commented Dec 30, 2018

SimenB commented Dec 30, 2018

necolas commented Dec 30, 2018

SimenB commented Dec 30, 2018

SimenB commented Dec 30, 2018

thymikee commented Jan 7, 2019

SimenB commented Jan 7, 2019

github-actions bot commented May 12, 2021

amosyuen commented Mar 22, 2018 •

edited

Loading

viknes-interana commented Dec 30, 2018 •

edited

Loading