-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unintended breaking change in snapshot tests in jest 23? #6262
Comments
robin-drexler
changed the title
Unintended breaking change in snapshot testing in jest 23?
Unintended breaking change in snapshot tests in jest 23?
May 25, 2018
It's called out in the changelog as a breaking change. Comes from #6162. |
ooops, overlooked that. Thank you! |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
💥 Regression Report
I've upgraded to jest 23 and found the following behavior change when it comes to undefined props in snapshots.
Last working version
v22.4.4
Worked up to version:
v22.4.4
Stopped working in version:
v23
To Reproduce
Consider the following test:
In jest 22 the resulting snapshot was:
Running the same test in jest 23 produces:
The
target={undefined}
has been removed, causing the test to fail.I could not find anything related to that in the changelog. Is this an intended change
Expected behavior
Snapshots should look the same as in in jest 22
Run
npx envinfo --preset jest
Paste the results here:
The text was updated successfully, but these errors were encountered: