Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CRA to generate frontend #2

Open
revmischa opened this issue Jan 10, 2021 · 4 comments
Open

Run CRA to generate frontend #2

revmischa opened this issue Jan 10, 2021 · 4 comments
Assignees

Comments

@revmischa
Copy link
Member

Is it possible to run create-react-app to spit out the frontend?

@Dizzzmas
Copy link
Contributor

I'm 95% sure it should be possible.

I'll look into that right after figuring out the proper serialisation and schema validation for endpoints as I think that should be higher priority now.

Would need to update our CRA template first with the Cognito stuff that we are using now.

@revmischa
Copy link
Member Author

Sounds great
The CRA npm i step fails right now installing storybook peer deps with npm 7 because of this bullshit btw:
storybookjs/storybook#12983
reach/router#436
storybookjs/storybook#12939
jamiebuilds/create-react-context#32

@Dizzzmas Dizzzmas self-assigned this Jan 11, 2021
@Dizzzmas
Copy link
Contributor

@revmischa
I think if there's a way to pass the --legacy-peer-deps flag to the npm i step of CRA it has good chances of fixing the problems with npm7.

Trying to research how to do it now.

@revmischa
Copy link
Member Author

I wouldn't worry too much about it; the storybook peer deps should be fixed sometime soon hopefully. People are dealing with it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants