Skip to content

Commit 11f70a9

Browse files
maelvlswallrj
andcommitted
PR comment from #35: use a self-signed issuer in the example
As Richard pointed out, there is no need to use openssl (and a Docker image of openssl that is not jetstack-branded) when we can simply use a self-signed issuer for the same purpose. Signed-off-by: Maël Valais <mael@vls.dev> Co-authored-by: Richard Wall <richard.wall@jetstack.io>
1 parent b3b1df9 commit 11f70a9

File tree

1 file changed

+12
-14
lines changed

1 file changed

+12
-14
lines changed

README.md

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,7 @@ disk. You can call it `agent-config.yaml`.
150150

151151
For the next step, make sure you have the following information available
152152
to you:
153+
153154
- The **namespace** and **cluster name** on which you installed the
154155
application. If you are not sure about this, you can open the
155156
[Applications](https://console.cloud.google.com/kubernetes/application)
@@ -196,8 +197,8 @@ kubectl -n $NAMESPACE rollout restart $(kubectl -n $NAMESPACE get deploy -oname
196197

197198
You may skip over the "Install agent" section:
198199

199-
<img src="https://user-images.githubusercontent.com/2195781/109156989-cb415b80-7771-11eb-910c-de247ad67ac2.png" width="600px" alt="Clicking on 'The agent is ready', you should see a green check mark. This screenshot is stored in this issue: https://github.com/jetstack/jetstack-secure-gcm/issues/21">
200-
=
200+
# <img src="https://user-images.githubusercontent.com/2195781/109156989-cb415b80-7771-11eb-910c-de247ad67ac2.png" width="600px" alt="Clicking on 'The agent is ready', you should see a green check mark. This screenshot is stored in this issue: https://github.com/jetstack/jetstack-secure-gcm/issues/21">
201+
201202
After skipping the "Install agent" section, follow the instructions in the
202203
"Check the agent is running" section.
203204

@@ -230,34 +231,31 @@ You can now click on "View clusters" to monitor your certificates. The
230231
documentation about the Jetstack Secure platform is available at
231232
<https://platform.jetstack.io/docs>.
232233

233-
Let us try with an example. We can create a CA issuer and sign a
234+
Let us try with an example. We can create a self-signed issuer and sign a
234235
certificate that only lasts for 30 days:
235236

236237
```sh
237-
docker run -it --rm -v "$(pwd)":/tmp frapsoft/openssl genrsa -out /tmp/ca.key 2048
238-
docker run -it --rm -v "$(pwd)":/tmp frapsoft/openssl req -x509 -new -nodes -key /tmp/ca.key -subj "/CN=example" -reqexts v3_req -extensions v3_ca -out /tmp/ca.crt
239-
kubectl create secret tls example-ca-key-pair --cert=ca.crt --key=ca.key
240238
kubectl apply -f- <<EOF
241239
apiVersion: cert-manager.io/v1
242240
kind: Issuer
243241
metadata:
244-
name: example-ca-issuer
242+
name: example-selfsigned-issuer
245243
spec:
246-
ca:
247-
secretName: example-ca-key-pair
244+
selfSigned: {}
248245
---
249-
apiVersion: cert-manager.io/v1alpha2
246+
apiVersion: cert-manager.io/v1
250247
kind: Certificate
251248
metadata:
252249
name: example-cert
253250
spec:
254251
duration: 721h # very short time to live
252+
secretName: example-cert-tls
253+
commonName: example-cert
255254
dnsNames:
256-
- example.com
255+
- example.com
257256
issuerRef:
257+
name: example-selfsigned-issuer
258258
kind: Issuer
259-
name: example-ca-issuer
260-
secretName: example-tls
261259
EOF
262260
```
263261

@@ -273,7 +271,7 @@ service that enables you to simplify, automate, and customize the
273271
deployment, management, and security of private certificate authorities
274272
(CA).
275273

276-
[Google Certificate Authority Service]: https://cloud.google.com/certificate-authority-service/
274+
[google certificate authority service]: https://cloud.google.com/certificate-authority-service/
277275

278276
If you wish to use [Google Certificate Authority
279277
Service](https://cloud.google.com/certificate-authority-service) to issue

0 commit comments

Comments
 (0)