Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky H2 tests #11735

Closed
gregw opened this issue May 2, 2024 · 3 comments
Closed

Flaky H2 tests #11735

gregw opened this issue May 2, 2024 · 3 comments
Labels
Bug For general bugs on Jetty side flaky-test

Comments

@gregw
Copy link
Contributor

gregw commented May 2, 2024

Jetty version(s)
12

Description
two unrelated PR builds failed with similar H2 issues:

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[2024-05-01T05:31:58.047+0000][info][gc] Using G1
WARNING: Unknown module: org.eclipse.jetty.http2.server specified to --add-reads
openjdk version "22" 2024-03-19
OpenJDK Runtime Environment Temurin-22+36 (build 22+36)
OpenJDK 64-Bit Server VM Temurin-22+36 (build 22+36, mixed mode, sharing)
[INFO] Running org.eclipse.jetty.http2.tests.TrailersTest
[INFO] Running org.eclipse.jetty.http2.tests.AsyncIOTest
Running org.eclipse.jetty.http2.tests.TrailersTest.testRequestTrailerInvalidHpackReceived()
Running org.eclipse.jetty.http2.tests.AsyncIOTest.testLastContentAvailableBeforeService()
2024-05-01 05:31:59.168:INFO :oejs.Server:ForkJoinPool-1-worker-1: jetty-12.0.9-SNAPSHOT; built: 2024-04-30T06:22:08.522Z; git: 52346e1574adb25994c66e320c9699c402e2ce18; jvm 22+36
2024-05-01 05:31:59.168:INFO :oejs.Server:ForkJoinPool-1-worker-2: jetty-12.0.9-SNAPSHOT; built: 2024-04-30T06:22:08.522Z; git: 52346e1574adb25994c66e320c9699c402e2ce18; jvm 22+36
2024-05-01 05:31:59.208:INFO :oejs.AbstractConnector:ForkJoinPool-1-worker-2: Started ServerConnector@3ca2ab87{h2c, (h2c)}{0.0.0.0:35859}
2024-05-01 05:31:59.208:INFO :oejs.AbstractConnector:ForkJoinPool-1-worker-1: Started ServerConnector@1157a1e9{h2c, (h2c)}{0.0.0.0:34631}
2024-05-01 05:31:59.216:INFO :oejs.Server:ForkJoinPool-1-worker-2: Started oejs.Server@ed77b26{STARTING}[12.0.9-SNAPSHOT,sto=0] @1171ms
2024-05-01 05:31:59.216:INFO :oejs.Server:ForkJoinPool-1-worker-1: Started oejs.Server@740d7a59{STARTING}[12.0.9-SNAPSHOT,sto=0] @1171ms
2024-05-01 05:32:09.653:WARN :oejut.QueuedThreadPool:ForkJoinPool-1-worker-1: Couldn't stop Thread[#44,client-44,5,main]
2024-05-01 05:32:09.653:WARN :oejut.QueuedThreadPool:ForkJoinPool-1-worker-2: Couldn't stop Thread[#43,client-43,5,main]
2024-05-01 05:32:09.654:INFO :oejs.Server:ForkJoinPool-1-worker-2: Stopped oejs.Server@ed77b26{STOPPING}[12.0.9-SNAPSHOT,sto=0]
2024-05-01 05:32:09.654:INFO :oejs.Server:ForkJoinPool-1-worker-1: Stopped oejs.Server@740d7a59{STOPPING}[12.0.9-SNAPSHOT,sto=0]
Sending interrupt signal to process
Hypertext Transfer Protocol Version 2 (HTTP/2)
  3. Starting HTTP/2
    3.5. HTTP/2 Connection Preface
      using source address 172.17.0.8:43102
      × 2: Sends invalid connection preface
        -> The endpoint MUST terminate the TCP connection.
           Expected: GOAWAY Frame (Error Code: PROTOCOL_ERROR)
                     Connection closed
             Actual: Error: unexpected EOF
@gregw gregw added the Bug For general bugs on Jetty side label May 2, 2024
@gregw
Copy link
Contributor Author

gregw commented Oct 1, 2024

@sbordet @lorban had this been addressed? Can this be closed?

@lorban
Copy link
Contributor

lorban commented Oct 2, 2024

The h2spec plugin was disabled in #12209, IIRC the last failure we spent time troubleshooting a failure the cause was the h2spec test itself.

@sbordet do you remember anything specific about this failure?

@sbordet
Copy link
Contributor

sbordet commented Oct 2, 2024

I am closing this.

@sbordet sbordet closed this as completed Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side flaky-test
Projects
None yet
Development

No branches or pull requests

3 participants