Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenId core authentication is storing a non-serializable attribute in a session #12307

Closed
janbartel opened this issue Sep 24, 2024 · 1 comment
Assignees
Labels
Bug For general bugs on Jetty side

Comments

@janbartel
Copy link
Contributor

Jetty version(s)
jetty-12.0.x

Jetty Environment
core

There is a bug in the core SessionHandler that has revealed that a session won't be written out as the response exits. See PR #12303.
This has revealed a problem in the core OpenId authentication - I'm not sure if this is just a problem with the test setup or a problem in the implementation, but once #12303 is fixed so the session will be saved on the way out of the response, the OpenId tests start to fail with java.io.NotSerializableException when the session is serialized. So there must be a session attribute that is non-serializable.

See:

https://jenkins.webtide.net/blue/organizations/jenkins/jetty.project/detail/PR-12303/3/pipeline

@janbartel
Copy link
Contributor Author

Closing in favour of opening a corrected issue - found the problem in SessionAuthentication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side
Projects
No open projects
Status: ✅ Done
Development

No branches or pull requests

2 participants