Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor #43

Open
walterimaican opened this issue Feb 14, 2021 · 0 comments
Open

Refactor #43

walterimaican opened this issue Feb 14, 2021 · 0 comments
Labels
tech debt Code quality needs improvement

Comments

@walterimaican
Copy link
Collaborator

There is some code duplication - for example, in expenses.js there is a function removeTimeZoneOffset whose function definition exactly matches that of groups.js removeTimeZoneOffset

This as well as any other duplicately defined code should be pulled out into a common file, such as a utils.js file.
@walterimaican walterimaican added the tech debt Code quality needs improvement label Feb 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech debt Code quality needs improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@walterimaican