-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Predict new data without training. #7
Comments
Do you mean using a previous training model (using the |
exactly |
Sorry, I have yet to implement that function since me personally had never use for it. Just to get the feeling how do you envision such an interface? When I started looking into this problem I felt that I would probably need to split Another alternative would be a separate |
I think first approach with train and predict methods more standard and clean, like in sklearn. Without that feature many ml techniques like stacking,blending become not so trivial. |
I'm also leaning towards that approach, since it meets one of my todo points
This weekend I have a little bit of time and I will start to work on this branch (that will break BC, so bumping version). Feel free to also submit changes |
Sorry, I'm not saw your todo . |
Hi @jfloff, |
I'm sorry, I haven't had time to dedicate to improving this. I realise that this feature would really improve running several different predictions, and I really want to improve it, but if I'm going to do it, I will inherit from sklearn.BaseEstimator right from the start (which takes a little bit more work). I have a deadline for Monday. After that I'll dig into this, I promise! :) The example is just to show how the API works, and what's the flow of libfm :) |
It seems that predict without a new train is not really supported at this moment. It seems that the functionality is not at 100% (e.g. not working for MCMC). I've also taken a look at libFM source code but I haven't had much success. Documentation is also lacking the save_model and load model function. I'm going on a limb here and ping @thierry-silbermann here since he was responsible for save_model and load_model in libFM. Could you give us some insight on how we should proceed |
Hi, here is how we could proceed to make a predict method: https://github.com/jilljenn/TF-recomm/blob/master/forward.py#L22 Where the pickled elements are those: https://github.com/jilljenn/TF-recomm/blob/master/fm_mangaki.py#L39 |
Want to try submit a PR for this? |
Yes. It will look like this. I don't know why I had sometimes to use Can you consider casting |
I don't see any problem with that. |
5 years later, I finally made a scikit-learn estimator: It will be improved over the next few days, then I can copy it in your repo. |
Can I predict new data by trained model? Or I always should call "run" method?
The text was updated successfully, but these errors were encountered: