Skip to content
This repository has been archived by the owner on Jul 22, 2021. It is now read-only.

Do not indefinitely retain failed favicon lookups #704

Open
jfroelich opened this issue Jan 26, 2019 · 0 comments
Open

Do not indefinitely retain failed favicon lookups #704

jfroelich opened this issue Jan 26, 2019 · 0 comments
Labels
favicon functionality related to favicons

Comments

@jfroelich
Copy link
Owner

Do not keep favicon lookup failure entries around forever, The failure guards should eventually let the request succeed somehow. Probably failure entries should also have an expiration period. But based on expires date set in entry instead of externally, so that I can have different expiration dates for non-failure cache items and failure cache items. The compact function could also check for these and remove expired

@jfroelich jfroelich self-assigned this Jan 26, 2019
@jfroelich jfroelich added the favicon functionality related to favicons label Feb 24, 2019
@jfroelich jfroelich removed their assignment Apr 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
favicon functionality related to favicons
Projects
None yet
Development

No branches or pull requests

1 participant