Skip to content
This repository has been archived by the owner on Jul 22, 2021. It is now read-only.

Analyze CSS properties in emphasis filter #723

Open
jfroelich opened this issue Jan 27, 2019 · 1 comment
Open

Analyze CSS properties in emphasis filter #723

jfroelich opened this issue Jan 27, 2019 · 1 comment
Labels
content filtering functionality related to content filtering

Comments

@jfroelich
Copy link
Owner

Currently, this ignores CSS rules due to the cost of computing styles. I think I can use getComputedStyle or the inline style and inspect emphasis-related properties. Also, if I use getComputed then maybe that takes into account the attribute values and element types so maybe the logic all becomes much simpler (e.g. a bold element means that text-weight inits to strong so there is no need to check against b/strong, just against the text-weight).
@jfroelich jfroelich self-assigned this Jan 27, 2019
@jfroelich jfroelich changed the title Analyze CSS properties in emphasis filter [dom-filters] Analyze CSS properties in emphasis filter Feb 24, 2019
@jfroelich jfroelich added the content filtering functionality related to content filtering label Feb 24, 2019
@jfroelich
Copy link
Owner Author

getComputedStyle is not available to inert documents. The only benefit would be considering inline style.

@jfroelich jfroelich changed the title [dom-filters] Analyze CSS properties in emphasis filter Analyze CSS properties in emphasis filter Mar 28, 2019
@jfroelich jfroelich removed their assignment Apr 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
content filtering functionality related to content filtering
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jfroelich