Add support for multiple policy in on block event #857
Conversation
asafambar
commented
Jul 3, 2023
asafambar
commented
- All tests passed. If this feature is not already covered by the tests, I added new tests.
- All static analysis checks passed.
- This pull request is on the dev branch.
- I used gofmt for formatting the code before submitting the pull request.
|
Description for PR: In order to show multi policies in a neat way in the table structure, I added the |
yahavi
changed the title
eyalbe4
added
ignore for release
| @@ -91,6 +92,36 @@ var DefaultMaxColWidth = 25 | |||
| // ┌─────────────────────────┐ | |||
| // │ No customers were found │ | |||
| // └─────────────────────────┘ | |||
| // | |||
| // Example(auto-merge): | |||
There was a problem hiding this comment.
// Example(auto-merge): --> // Example (auto-merge):
| policies = append(policies, Policy{Policy: strings.TrimSpace(pol), Condition: strings.TrimSpace(cond)}) | ||
| } | ||
| } | ||
| return policies | ||
| } | ||
|
|
||
| // Adding a new line after the headline and replace every "|" with a new line. | ||
| func makeLegiblePolicyDetails(explanation, recommendation string) (string, string) { |
There was a problem hiding this comment.
Let's a unit test for this frunction.
There was a problem hiding this comment.
I have unit test for the function which using it, anyway, I can add dedicated one
