Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the main.go path to ../main.go #2057

Closed
wants to merge 1 commit into from
Closed

Changed the main.go path to ../main.go #2057

wants to merge 1 commit into from

Conversation

YonatanHen
Copy link

@YonatanHen YonatanHen commented Jul 2, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

When attempting to run the build on MacOS using the 'sh build.sh' command, the build process encountered a failure due to an incorrect path of the main.go file, with the following message:
no required module provides package main.go; to add it: go get main.go
However, after modifying the build.sh file and updating the path to ../main.go, the build process was successful.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@YonatanHen
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@YonatanHen
Copy link
Author

recheck

@yahavi
Copy link
Member

yahavi commented Jul 3, 2023

Hi @YonatanHen ,
In order to build the JFrog CLI, we run the following command from the root of the repository:

./build/build.sh

After this PR is merged, it will not work anymore.

@yahavi yahavi closed this Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants