Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiselection capability to the file input button #48

Open
aluttik opened this issue Dec 2, 2015 · 4 comments
Open

Add multiselection capability to the file input button #48

aluttik opened this issue Dec 2, 2015 · 4 comments

Comments

@aluttik
Copy link

aluttik commented Dec 2, 2015

http://www.w3schools.com/tags/att_input_multiple.asp

@jglamine
Copy link
Owner

jglamine commented Dec 2, 2015

This is something we've wanted for a while, but we've never had tome to do it. You're welcome to submit a pull request. I'd be happy to review it.

@aluttik
Copy link
Author

aluttik commented Dec 2, 2015

okay 👍 I'll take a look when I get the chance

do you know if the problem more complicated than adding the word "multiple" to #file-input?

@jglamine
Copy link
Owner

jglamine commented Dec 2, 2015

Awesome, thanks!

It's been a while since I've taken a look at it, so I'm not sure. I think the reason we didn't implement this is its more complicated than that. Take a look at the callback on the front end which runs once a file is selected, and then follow the code from there.

The tricky part is deciding what to do if some but not all of the files submit correctly. For example, some of them are the wrong file type, some of them are too big, some fail to upload because of network issues, and some succeed. Well probably want to display success / failure next to each file, or just an error message at the top for each file.

If you could look into it and let me know what you think, that would be awesome!

@jglamine
Copy link
Owner

jglamine commented Dec 2, 2015

My advice is to start building just getting multi upload to work, then adding error handling after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants