Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --epub-stylesheet; just use --css #3472

Closed
jgm opened this issue Feb 26, 2017 · 0 comments
Closed

Remove --epub-stylesheet; just use --css #3472

jgm opened this issue Feb 26, 2017 · 0 comments

Comments

@jgm
Copy link
Owner

jgm commented Feb 26, 2017

One problem with --epub-stylesheet is that multiple stylesheets can't be specified (#847).
Another is that it works by setting the css variable of templates (in the EPUB writer), which will have bad results if the --css option was used too.
Better and less confusing if we just allow --css to be used with epub, and get rid of --epub-stylesheet.

That means we can get rid of the writerEpubStylesheet field of WriterOptions.
The EPUB writer will look at variables for css. If no css files are specified in this way, we'll insert the default stylesheet as we do now. If css files are specified, they'll be copied to entries in the epub container, with appropriate names, and the variables will be changed to match the new names. We'll also have to change the code that contructs the manifest, so entries for all CSS files used get in.

All in all, not a huge change.

This replaces #847.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant