Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid depth attribute in docx to TEI #4331

Closed
joeytakeda opened this issue Jan 31, 2018 · 2 comments
Closed

Invalid depth attribute in docx to TEI #4331

joeytakeda opened this issue Jan 31, 2018 · 2 comments

Comments

@joeytakeda
Copy link

Using 2.1.1 and converting from docx to TEI. For images in docx, the result TEI has an invalid @depth attribute. Should this be height?

When the attached file is converted using command:

pandoc -f docx -t tei sample.docx

The result TEI is:

<p>
<figure>
<graphic url="media/image1.png" width="5.06875in" depth="2.66109in" />
</figure>
</p>

I suggest that graphic/@depth should be changed to graphic/@height:

<graphic url="media/image1.png" width="5.06875in" height="2.66109in" />
@jgm
Copy link
Owner

jgm commented Jan 31, 2018

Seems plausible to me, but I don't know anything about TEI.
Let's see if @c-forster (who contributed the TEI writer) had a reason for using depth instead of height?

@c-forster
Copy link

That seems like an outright error to me. depth is not a valid attribute in TEI. I built the TEI writer by modifying the DocBook writer, and in DocBook the imagedata element takes width and depth, so I suspect that is the source of this error.

@jgm jgm closed this as completed in 8bdbdc2 Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants