Installs, stages, and builds the client-side scripts necessary for running the
Galaxy webapp. When started through run.sh or any other method that utilizes
scripts/common_startup.sh, Galaxy will (since 18.09) automatically build
the client as a part of server startup, when it detects changes, unless that
functionality is explicitly disabled.
The base dependencies used are Node.js and Yarn. Galaxy now includes these in
the virtual environment, and they can be accessed by activating that with . .venv/bin/activate from the Galaxy root directory.
If you'd like to install your own dependencies, on OSX the easiest way to get
set up is using homebrew and the command brew install nodejs yarn. More
information, including instructions for other platforms, is available at
https://nodejs.org/ and https://yarnpkg.com/ .
The Galaxy client build has necessarily grown more complex in the past several years, but we are still trying to keep things as simple as possible for everyone. If you're having any trouble with building the client after following the instructions below, please create an issue on GitHub or reach out for help directly on Gitter at https://gitter.im/galaxyproject/Lobby .
There are many moving parts to the client build system, but the entry point for most people is the 'client' rule in the Makefile at the root of the Galaxy repository. Execute the following to perform a complete build suitable for local development, including dependency staging, style building, script processing, and bundling. This is a development-specific build which includes extra debugging features, and excludes several production optimizations made during the build process.
make client
For a production build, suitable for deploying to a live server, use the following:
make client-production
And, lastly, if you want a production build that includes sourcemaps to allow for inspection of live javascript to facilitate debugging, use:
make client-production-maps
Important Note: The Galaxy repository does not include client script artifacts, and these should not be committed.
When you're actively developing, it is sometimes convenient to have the client automatically rebuild every time you save a file. You can do this using:
make client-watch
This will first stage any dependencies (yarn-installed packages like jquery,
etc), and then will watch for changes in any of the galaxy client source files.
When a file is changed, the client will automatically rebuild, after which you
can usually force refresh your browser to see changes. Note that it is still
recommended to run make client after you are finished actively developing
using make client-watch.
Galaxy uses Sass for its styling, which is a superset of CSS that compiles down to regular CSS. Most Galaxy styling source (.scss) files are kept in `client/galaxy/style/scss. There are additionally style blocks alongside some Vue components -- styles that are particular to that individual component and do not apply site-wide.
On build, the compiled css bundle is served at /static/style/base.css.
As mentioned above, make client will rebuild styles, as a part of the webpack
build. For iterative development, "Watch Mode" rebuilds as described above do
include style changes.
Galaxy's client is undergoing an extensive refactoring and modernizing process. As part of this initiative, we would like to request that all new client-side code submissions come with accompanying javascript unit-tests for the developer-facing API of your new code.
Galaxy uses Mocha for its client-side unit testing framework with Chai as its assertion library and karma as a test runner. The karma configs are contained in the client/karma folder. Unit tests are run using Chrome headless by default.
For testing Vue components, we use the Vue testing utils to mount individual components in a test bed and check them for rendered features.
We use the babel plugin Rewire to mock imported ES6 dependencies during unit-testing. Sinon is also available for more robust stubbing, mocking and spying utilities.
A set of older qUnit tests also exist which will likely be phased-out as the code they support is replaced with modern component-based implementations. In the meantime, karma runs both the mocha and qunit tests in sequence.
To simply run all the javascript unit tests, you can use make from the root directory. This is what happens during a complete client build.
make client-test
During client-side development, it is more convenient to have granular testing options. The various testing scripts are defined inside package.json within the client folder, and are called either with npm (or yarn) as follows:
npm run test
npm run test-watch
npm run test-watch watch-only="Tags/*.test.js"
(The above watch-only parameter will be mapped to the following glob expression "**/Tags/*.test.js")
npm run test-qunit
The karma configs are setup to look at any file ending in "*.test.js". Please place your test files inside client/galaxy/scripts folders right next to whatever files that they are testing.
// yourtestfile.test.js
import { things } from "./yourtestfile.js";
describe("some module you wrote", () => {
let transientVariables, serviceInstances, testData;
beforeEach(() => {
// setup your code (if necessary)
})
afterEach(() => {
// teardown your code (so it doesn't ruin the next test)
})
it("should do something or other", () => {
assert(somethingThatShouldTrue, "explain what went wrong");
expect(something).to.eq(true);
})
})Please remember that these tests are not for you. They're for the people who come after you. It will be a lot easier to modify, repair and upgrade your code if they can figure out what you were originally hoping to accomplish.
Add a couple of comments. Use variable names that mean something. Use the assertion failure description parameters when possible. Nobody's code is as self-documenting as they believe it to be.
// NOT AWESOME
// this test forces the next victim to have to
// read every single line of source code you wrote
it("should work", async () => {
let thing = await svc.loadHistories();
assert(thing);
})
// BETTER
// With this test, you can just read at the errors on the mocha
// test output to have a pretty good idea of what went sour.
it("should have resolved to an array of integer IDs", async () => {
let historyIds = await historyService.loadHistories();
assert(historyIds, "History service should have had a result");
assert(historyIds instanceof Array, "History results should have been an array");
assert(historyIds.length == 4, "History call should have returned 4 ids");
})Internal implementations come and go with library upgrades and new tech. But the point of the unit test is to make sure your units work as designed.... which means you need to... you know... design your code to work in units.
Separate your concerns and identify the developer-facing methods and functions you expect them to use. Test THOSE. Everything else should probably be considered an implementation detail.
Assume nobody cares how your code works, we just need to know that the public API you designed does work. If performance problems or new tech necessitate a re-write, these tests become a guide for the next implementation.
If your javascript needs to talk to the window object, or navigator, etc. wrap that in a function call so that it can be easily mocked during testing.
// myModule.js
// ... other code
export function redirectTo(url) {
window.location = url;
}
// myModule.test.js
import { __RewireAPI__ as myModuleRewire} from "./myModule";
function fakeRedirect(url) {
console.log(`I would have gone to: ${url}`);
}
describe("some module", () => {
beforeEach(() => {
myModuleRewire.__Rewire__("redirectTo", fakeRedirect);
})
// ....
})The more of your logic that is written in deterministic functions (i.e. no side-effects, same inputs always result in same outputs) the easier it is to test. Just load up the functions and supply suitable test inputs.
There is almost definitely no such thing as a well-written 1000 line function. Most of whatever happened in that thing was probably deterministic and can be broken up into easily testable chunks.
Mocking an imported dependency
Testing a Vue component for expected rendering output
Firing an event against a shallow mounted vue component
It's good to have tests, but testing code isn't really about testing at all, it's actually about software design.
Maintainable software is testable software. If you can run a unit test on your code, then that means you must have necessarily separated your code into testable units and you will have almost definitely written better, more modular, more easily manipulated code, and nobody will ever contemplate using git-blame to figure out what went wrong.
Probably.