Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip-review also updates pip, maybe mention that in the Readme #59

Closed
ABruihler opened this issue Oct 24, 2017 · 2 comments
Closed

pip-review also updates pip, maybe mention that in the Readme #59

ABruihler opened this issue Oct 24, 2017 · 2 comments
Assignees
Milestone

Comments

@ABruihler
Copy link

Quick question that I'm not knowledgable enough to figure out the answer myself and haven't been able to find out through searching - does pip-review update pip itself, or not? Also, would this be good to mention in the README, or is it just something that's obvious to everyone except me?

@jgonggrijp jgonggrijp self-assigned this Oct 24, 2017
@jgonggrijp
Copy link
Owner

As of version 1.0, pip-review is a thin wrapper around pip. The status as a wrapper is documented, both in the Readme and in pip-review -h. Pip does update itself, so yes, pip-review will update pip. Basically, neither pip nor pip-review will make an exception for any package. Do you believe that belongs in the Readme?

@ABruihler
Copy link
Author

Thanks! I guess that somehow I hadn't made that connection and hadn't checked to see if pip updates itself. I do think that it would be helpful for some to include this in the Readme, perhaps in something like a FAQ at the bottom, or by change the example to include upgrading pip? On the other hand, I suppose it is something that should be pretty apparent (especially with an issue about it now), and possibly not worth the space in the README.

@jgonggrijp jgonggrijp changed the title Does pip-review update pip? pip-review also updates pip, maybe mention that in the Readme Jan 20, 2018
@jgonggrijp jgonggrijp removed their assignment Sep 21, 2018
@jgonggrijp jgonggrijp removed the poll label Sep 28, 2018
@jgonggrijp jgonggrijp self-assigned this Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants