Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle 404 Errors in GitLab Group Iteration #4528

Open
2 tasks done
Meli1Git opened this issue Jul 8, 2024 · 2 comments
Open
2 tasks done

Handle 404 Errors in GitLab Group Iteration #4528

Meli1Git opened this issue Jul 8, 2024 · 2 comments

Comments

@Meli1Git
Copy link

Meli1Git commented Jul 8, 2024

Preflight Checklist

  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Describe the bug
When making requests to the GitLab API, a 404 error can occur if the user lacks permissions or if the resource does not exist. GitLab returns a 404 status code in both cases to avoid revealing restricted resources.

To Reproduce
Steps to reproduce the behavior:

  1. In GitLab, be attached to two groups: one where you have the necessary permissions to read the group's projects, and another where you do not. In GitLab, you can see that you are attached to this second group, but when you click on it, you see a 404 error.
  2. Go to the draw.io instance and try to export your diagram to GitLab. At this point, it will iterate through all groups/projects, and you will encounter a "404 Group Not Found" error.

Expected behavior
If a 404 error is encountered during /groups/xxx/projects iteration, it should be ignored, allowing the iteration to continue through other groups. This is explained in my pull request: Ignore 404 errors in GitLab group iteration #4450.

Screenshots
image

draw.io version (In the Help->About menu of the draw.io editor):

  • draw.io version 24.4.8

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Browser Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

I tested the problem in incognito/private mode with all browser extensions switched off, write "yes" below:

  • yes

Additional context
I initially opened a pull request to address this issue: Ignore 404 errors in GitLab group iteration #4450. However, since the project does not accept contributions from non-staff members, I am creating this issue for consideration.

Thank you for your attention.

@davidjgraph
Copy link
Collaborator

Could you test again with the latest build please?

@Meli1Git
Copy link
Author

Meli1Git commented Jul 9, 2024

@davidjgraph I have tested version 24.6.4, and the issue persists.
image
The iteration stops with a "404 Group Not Found" error as soon as it encounters a group where we do not have access to the projects, and it ignores all other groups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants