Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unreliable onedrive login #4742

Open
2 tasks done
ciis0 opened this issue Nov 7, 2024 · 0 comments
Open
2 tasks done

unreliable onedrive login #4742

ciis0 opened this issue Nov 7, 2024 · 0 comments

Comments

@ciis0
Copy link

ciis0 commented Nov 7, 2024

Preflight Checklist

  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Describe the bug

Initial OneDrive login works fine, but internal refresh does not seem to work reliably.

Especially for the "Open Existing Diagram" from initial dialog (Screenshot 1) the authentication seems to be buggy

To Reproduce
Steps to reproduce the behavior:
0. ensure you have set inlinePicker=0, e.g. using https://app.diagrams.net?inlinePicker=0

  1. drawio should not be logged in to OneDrive yet (i.e. show "choose storage", screenshot 2)
  2. login to OneDrive now, observe login and "Open Existing Diagram" works fine
  3. reload the page
  4. try "Open Existing Diagram", sometimes this does not work (screenshot 4)
  5. reload again
  6. try "Open Existing Diagram", as far as i can tell this reliably does not work (also screenshot 4).

Expected behavior

the "Open Existing Diagrams" button should work reliably.

Screenshots

Screenshot 1:
image

Screenshot 2:
image

Screenshot 3:
image

Screenshot 4:
image

draw.io version (In the Help->About menu of the draw.io editor):

  • draw.io version 24.8.4

Desktop

  • OS: Windows
  • Browser Firefox 132.0, Edge 130.0.2849.68

I tested the problem in incognito/private mode with all browser extensions switched off, write "yes" below:

  • yes.

Additional context

it seems that depending on how to onedrive picker is started, it seems a different set of scopes (also in different format?) is requested and rejected (using developer tools network tab and the "referrer" of the login page because I just can't hit f12 fast enough to get the initial request :D)

a successful login seems to request these scopes:

profile openid https://graph.microsoft.com/User.Read https://graph.microsoft.com/Files.Read.All

while i see the following scopes during initial login:

user.read files.readwrite.all sites.read.all offline_access

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant