Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement equals() / hashcode() for Address #3

Open
belaban opened this issue Nov 22, 2023 · 0 comments
Open

Implement equals() / hashcode() for Address #3

belaban opened this issue Nov 22, 2023 · 0 comments
Assignees
Milestone

Comments

@belaban
Copy link
Member

belaban commented Nov 22, 2023

Protobuf generates code for equals() and hashcode() which compares all fields. This is not needed, or even incorrect: for example, name in Address is not needed and can even be empty.

Implement equals() and hashcode() for Address. They can then be used as Comparator for hashmaps/sets etc.

@belaban belaban self-assigned this Nov 22, 2023
@belaban belaban transferred this issue from jgroups-extras/RollingUpgrades Dec 4, 2023
@belaban belaban added this to the 1.1 milestone Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant