Disable isDragging when element is destroyed #150
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging an issue in an application, we came across a case where the act of dragging an element caused re-renders and actively-dragging-element destruction.
In this scenario, ember-sortable would endlessly scroll the page to the top of the screen because the
isDragging
flag remained true (once dragging began) even after the element was destroyed. This occurred because the_scrollOnEdges
method usesrequestAnimationFrame
to recursively call itself while dragging. If the element is destroyed and isDragging is forever true, these recursive calls will never end.