-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alias sortable direction to group #151
Alias sortable direction to group #151
Conversation
47de4fb
to
6e1d257
Compare
@jgwhite @acburdine any thoughts about this? |
So I'm fine with this change for the 1.x branch I think - my idea with a 2.0 release (once I get around to cleaning some stuff up 😬) is to refactor how properties are passed between the two components, so instead of passing the entire group just the needed properties would be transferred. |
Ok, great! What way are you thinking of? Should I change the pr to a different branch? |
@acburdine can this be merged soon? |
@acburdine is there anything that is keeping this from being merged? Please let me know if you need anything from me |
Sorry we haven’t moved forward on this. I hope to get up to speed on it soon and get back to you with the next step. |
6e1d257
to
da463d2
Compare
da463d2
to
f5f4e5c
Compare
Thanks so much for the patch! I’ll try to release it later today! |
@jgwhite awesome, thanks a lot! |
We are using this addon in an application where
group
is already a thing in many places.Therefore we would like to use a different name for that variable.
With this change we only have to override
_direction
and_tellGroup
instead of having to copy complete methods.Let me know if this is desired or if you know a better way!