-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecation warnings in browser console #8
Comments
Thanks for the notification. But it seems to me that the error messages are not related to rewire-webpack because I don't use these properties. There are actual just a few lines of code of rewire-webpack that run in the browser. The main part is done during webpack compilation. Both warnings are caused by the same problem: I guess you're using some browser-based database (Probably level.js or indexedup?) which tries to access deprecated properties. |
It's interesting .. because if i dont use rewire in my test file warning disappears.. Maybe can be problem with phantomJS which I'm using to open final test bundle.. (but with warnings only if i use rewire) hmm .. i will have to explore more deeply.. |
The warnings appears at getImportGlobalsSrc function on line 28 |
Ah, that makes sense... the warnings are outputted when such a property is accessed. It's safe to ignore these warnings. Unfortunately rewire still needs to access these variables because there might be code mocking these properties although they are deprecated now. |
Is this still an issue? I'll try it out now on 1.7.*. If ever, I'll update the outcome. |
Yep, it will not go away soon. rewire needs to access these properties... |
Alright 😄! But these are merely warnings and do not affect test results, right? |
Yep, they occur because the browser thinks that your application is accessing these deprecated properties. |
Hi,
Firstly, I would like to thank you for very useful module.
I'm using rewire with webpack bundle, but after upgrade webpack to version 1.4.13 I'm getting some warning messages in console.log
Warning 1:
Warning 2:
But everything seems that works properly yet. But I write better now than when it's too late.
The text was updated successfully, but these errors were encountered: