Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] progress text option for fullscreen mode #549

Closed
marcoberetta96 opened this issue Jun 11, 2021 · 2 comments
Closed

[FEATURE] progress text option for fullscreen mode #549

marcoberetta96 opened this issue Jun 11, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request info required The issue author didn't provide required informations.

Comments

@marcoberetta96
Copy link

When showing a small video (for example half of screen), using both enableProgressText: true and enableProgressBar: true probably causes an overflow.

It should be nice if we cloud have an enableProgressTextWhenFullscreen so that the progress text could be enabled only when the betterplayer is in fullscreen mode.

@marcoberetta96 marcoberetta96 added enhancement New feature or request new issue New issue which has not been checked yet labels Jun 11, 2021
@jhomlala
Copy link
Owner

jhomlala commented Jun 20, 2021

@marcoberetta96 Did you see #535? Please fix your issue ticket properly. Also please provide sample code.

Anyway your issue is related with your app and probably you should use custom theme where you will opt in/out displaying progres bar I believe showing both progress text and progress bar in small Better Player widget is useless because user will have problem with using that seekbar.

@jhomlala jhomlala added info required The issue author didn't provide required informations. and removed new issue New issue which has not been checked yet labels Jun 20, 2021
@jhomlala
Copy link
Owner

jhomlala commented Jul 6, 2021

Closed due to no activity from author.

@jhomlala jhomlala closed this as completed Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request info required The issue author didn't provide required informations.
Projects
None yet
Development

No branches or pull requests

2 participants