Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the Option types' is_some and is_none methods to take &self (by reference) rather than self (owned value) #16

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

babichjacob
Copy link

closes #15

…o take `&self` (by reference) rather than `self` (owned value)
@babichjacob
Copy link
Author

babichjacob commented Oct 31, 2024

No changes to time will have to be made besides specifying the new version after it's bumped: it still compiles and tests successfully when patching the dependency in local testing.

@babichjacob
Copy link
Author

The Formatting job initially failed cause there are new (since the last run) disagreements between stable and nightly Rust about how to sort some imports and format one other miscellaneous line, so I pushed a formatting commit just to make it pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OptionRanged[something]'s is_none and is_some methods take ownership of the value
1 participant