Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HTTPS Proper #27

Open
jhuckaby opened this issue May 2, 2017 · 3 comments
Open

Support HTTPS Proper #27

jhuckaby opened this issue May 2, 2017 · 3 comments
Assignees

Comments

@jhuckaby
Copy link
Owner

jhuckaby commented May 2, 2017

Cronicle has various issues when HTTPS mode is enabled on the underlying WebServer component, especially when https_force is also enabled. This forces server-to-server requests to use HTTPS, which fails because they also use IP addresses. See Issue #26 for at least one case. Example error (copying logs between servers):

Failed to fetch job log file: https://172.17.2.143:3012/api/app/fetch_delete_job_log?path=%2Fhome%2Fdeployer%2Fcronicle%2FCronicle-0.6.11%2Flogs%2Fjobs%2Fjj26j9mdn02.log&auth=removed: Error: Error: Hostname/IP doesn't match certificate's altnames: "IP: 172.17.2.143 is not in the cert's list: "

We need to fully test HTTPS mode, especially in a multi-server environment, and dig out all the possible issues that may arise.

@dropthemic
Copy link

@jhuckaby I've added reverse proxy support (#65) so you can use apache or nginx to handle the SSL.

@jhuckaby
Copy link
Owner Author

@dropthemic Thank you! Will check it out when I have some time.

@edewillians10
Copy link

I am not able to set up SSL certs ... not sure if this is bug or not ... but I already tried with different ways but no luck ... could someone help me out ?

this is the error I am getting when I try to enable "https" : false

[1637002200.049][2021-11-15 11:50:00][cronicle-server][19362][WebServer][debug][2][Starting HTTPS (SSL) server on port: 443][]
Error: error:0906D06C:PEM routines:PEM_read_bio:no start line
    at Object.createSecureContext (_tls_common.js:88:17)
    at Server (_tls_wrap.js:805:25)
    at new Server (https.js:54:14)
    at Object.createServer (https.js:76:10)
    at WebServer.startHTTPS (/opt/cronicle/node_modules/pixl-server-web/lib/https.js:53:33)
    at /opt/cronicle/node_modules/pixl-server-web/web_server.js:179:10
    at Server.<anonymous> (/opt/cronicle/node_modules/pixl-server-web/lib/http.js:224:4)
    at Object.onceWrapper (events.js:313:30)
    at emitNone (events.js:106:13)
    at Server.emit (events.js:208:7)
root@5-88-phx:/opt/cronicle/conf#

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants