Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

["Problem"] previewing new chapters #378

Closed
KatherineCox opened this issue Jan 11, 2022 · 1 comment · Fixed by #380
Closed

["Problem"] previewing new chapters #378

KatherineCox opened this issue Jan 11, 2022 · 1 comment · Fixed by #380
Assignees
Labels
bug Something isn't working

Comments

@KatherineCox
Copy link
Contributor

Describe what is not working with the template or is unclear in the documentation

I haven't tested thoroughly, but I've noticed a couple times that the auto-generated preview has trouble with newly created chapters.

If I merge the PR, the new chapter renders fine and the links work in the "published" bookdown; it's just in the preview that it's broken.

Please link to the specific course repository you are working on

jhudsl/AnVIL_Book_Getting_Started#127

Here's an open PR demonstrating the problem. I've added a new chapter at the end of the book (as Appendix H). The link shows up in the toc, but it's broken (404 error).

I saw the same problem on this PR (adding "Appendix B: Troubleshooting"), but now that I've merged it the chapter shows up as expected in the published book (and the preview is gone, so, you can't see the problem there).

To Reproduce

  1. Clone/pull repo and make branch
  2. Add a new chapter (.Rmd file), also add it to _bookdown.yml. This renders fine locally.
  3. Push changes (.Rmd file, _bookdown.yml) and make a PR
  4. View the autogenerated GitHub preview (Bookdown) and try to view the new chapter. The new chapter shows up in the table of contents, but I get a 404 error if I try to click on it.

This repo has been synced with the OTTR_Template repo as of the most recent release, so the github actions should be up-to-date minus any changes made since then.

@KatherineCox KatherineCox added the bug Something isn't working label Jan 11, 2022
@cansavvy
Copy link
Collaborator

I'll take a look into this, @KatherineCox Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants