Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have one core GitHub actions set of files that are called by users's github actions #502

Closed
cansavvy opened this issue Mar 11, 2022 · 5 comments
Assignees

Comments

@cansavvy
Copy link
Collaborator

Duh, this was in front of my all along and I didn't think of it.

We could reference a main copy of the OTTR github actions that are here and not require people to make copies! This would make it so people can more easily customize files like "pull-request.yml" and wouldn't have to depend on the sync PRs to update the GHA.

Instead pull-request.yml would just have a series of things like this:

jobs:
  reusable_workflow_job:
    runs-on: ubuntu-latest
    steps:
      - uses: jhudsl/OTTR_Template/.github/workflows/style-code.yml 
```
@cansavvy
Copy link
Collaborator Author

Publishing the github actions would make them even easier to reference: https://docs.github.com/en/actions/creating-actions/publishing-actions-in-github-marketplace

@cansavvy
Copy link
Collaborator Author

I've started a separate repo for this purpose: https://github.com/jhudsl/OTTR_Actions

The idea would be the core github actions are stored here and then called from course's own repositories. This allows for less redundancy and easier for customizing purposes.

@cansavvy
Copy link
Collaborator Author

Step 1: I'm working on setting up a Reusable workflow: https://docs.github.com/en/actions/using-workflows/reusing-workflows here https://github.com/jhudsl/OTTR_Actions/pulls
Step 2: Re-set pull-request.yml to use those github actions from OTTR_Actions
Step 3: Modify documentation where needed.

@cansavvy
Copy link
Collaborator Author

The first half of these actions are on Marketplace: https://github.com/marketplace/actions/ottr-reports Yay!

@cansavvy
Copy link
Collaborator Author

This is done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant