Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL checker action is not cooperating with Rmds anymore #514

Closed
cansavvy opened this issue Mar 22, 2022 · 2 comments
Closed

URL checker action is not cooperating with Rmds anymore #514

cansavvy opened this issue Mar 22, 2022 · 2 comments

Comments

@cansavvy
Copy link
Collaborator

Even though I've tried going back to earlier versions of https://github.com/urlstechie/urlchecker-action/tree/0.2.3, it still is not cooperating with scanning Rmds anymore. It always tells me "no URLs detected"

I think this is because https://github.com/urlstechie/urlchecker-action/blob/master/entrypoint.sh hasn't frozen what version they use and updates to the python urlchecker pacakge that is underneath the hood: https://quay.io/repository/urlstechie/urlchecker/manifest/sha256:65edb42c5fda47c6b8668cee59b59d1eeb9e2b432711cdd3415bc569cfcfd635

SO, I think we should just switch strategies, and maybe use the package they use directly instead of using their action.

@cansavvy
Copy link
Collaborator Author

cansavvy commented Apr 1, 2022

The fix for this is pushed, I'm just testing it out on various repositories before I send out the next release.

@cansavvy
Copy link
Collaborator Author

cansavvy commented Apr 1, 2022

It's working! The only thing left is to provide a way for url's to be ignored, but I think this can be a later priority. Going to make a new issue for this.

@cansavvy cansavvy closed this as completed Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant