Adding embed functionality for Leanpub conversion #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/implementation Section
What changes are being implemented in this Pull Request?
This is working to address: jhudsl/OTTR_Template#381
Adding functions here that will create markdowns with iframes for Leanpub.
What was your approach?
The way this works is that you can give a TSV that has chapter urls and specifies image paths for each. You can supply a default image for all chapters, or if you don't supply any images there's a default OTTR image that will be used for you.
The main function is (at it's minimum arguments specified is:
ottr::bookdown_to_embed_leanpub(base_url)The one required item is that you must specify the base_url.
These functions will be called by Github actions in OTTR_Template and OTTR_Quizzes.
What GitHub issue does your pull request address?
jhudsl/OTTR_Template#381