Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo app impacted by turbolinks compatibility issue. #103

Closed
richlarcombe opened this issue Aug 31, 2016 · 3 comments
Closed

Demo app impacted by turbolinks compatibility issue. #103

richlarcombe opened this issue Aug 31, 2016 · 3 comments

Comments

@richlarcombe
Copy link

Having experienced what i thought was pagination related issues breaking the expected operation of Demo app.
It would appears the culprit was due to some 'ready event problems caused by Turbolinks5' (which is now installed by default)
Downgrading to using gem 'turbolinks', '~> 2.5.3' fixed things up to some degree, filterriffic behaved better but there was still an issue with needing to double click pagination links.
Using jquery.turbolinks then solved this.

Suggests that maybe a change in filterrific to ensure compatibility with turbolinks5 would be helpful if anyone has the time?

@genezys
Copy link

genezys commented Sep 16, 2016

Turbolinks 5 has changed its events to turbolinks: instead of page:.

If you look at https://github.com/jhund/filterrific/blob/master/app/assets/javascripts/filterrific/filterrific-jquery.js#L83, you can see that Filterrific only listen to the page:load event and should also listen to turbolinks:load to be compatible with Turbolinks 5.

I will submit a PR for this change.

@genezys
Copy link

genezys commented Sep 16, 2016

My bad, it appears that PR #87 already solved this issue.

@jhund
Copy link
Owner

jhund commented Nov 12, 2016

This has been fixed with 2.1.2 release

@jhund jhund closed this as completed Nov 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants