Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Boolean Filters in Filterrific Gem - Incorrect Handling of "False" Values #223

Open
grantmca opened this issue Aug 8, 2023 · 0 comments

Comments

@grantmca
Copy link

grantmca commented Aug 8, 2023

When passing a boolean value of false as a filter parameter from the controller, the gem treats it as non-present due to the .present? check performed during the define_and_assign_attr_accessors_for_each_filter method. As a result, the parameter isn't assigned to the attr_accessor and doesn't affect the filtering process. Is this the expected behavior of the gem? If not I could look into making a PR to address this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant