Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create sentry key (DSN)? #14

Closed
mwarkentin opened this issue Oct 23, 2017 · 6 comments
Closed

Create sentry key (DSN)? #14

mwarkentin opened this issue Oct 23, 2017 · 6 comments
Assignees

Comments

@mwarkentin
Copy link
Contributor

It'd be great if we could also create a sentry key for a project during creation, in order to provide it in an output.

They provide APIs to create/list/delete keys:

I suppose this would probably be it's own resource rather than being part of the project.

@mwarkentin
Copy link
Contributor Author

Alternatively, a data source to get a list of keys by projects would probably work for us as well, as projects have a default key created along with the project automatically.

@jianyuan
Copy link
Owner

jianyuan commented Oct 25, 2017

@mwarkentin I prefer to have 1 to 1 correspondence between the API resource endpoints and Terraform resources.

The data source is a good idea. I will implement it sometime this week.

@jianyuan jianyuan self-assigned this Oct 25, 2017
@mwarkentin
Copy link
Contributor Author

@jianyuan Agreed, after looking at the API, I think it would make most sense as a separate sentry_project_key. Looking forward to it!

@jianyuan
Copy link
Owner

jianyuan commented Nov 1, 2017

At the moment, Terraform's data source does not support returning multiple entities.

In Sentry, a key is differentiated by its name and ID.

I think I found a good compromise: If there's only 1 project key, which is the case when a project is newly created, then the project key name or ID is optional. Otherwise, the data source should error and notify the user to add appropriate filtering.

@mwarkentin
Copy link
Contributor Author

That sounds reasonable to me!

@mwarkentin
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants