Skip to content

Commit

Permalink
Rollup merge of rust-lang#127367 - ChrisDenton:run-sync, r=Nilstrieb
Browse files Browse the repository at this point in the history
Run alloc sync tests

I was browsing the code and this struck me as weird. We're not running some doc tests because, the comment says, Windows builders deadlock. That should absolutely not happen, at least with our current implementation. And if it does happen I'd like to know.

Just to be sure though I'll do some try builds.

try-job: x86_64-msvc
try-job: i686-msvc
try-job: i686-mingw
try-job: x86_64-mingw
  • Loading branch information
jieyouxu authored Jul 8, 2024
2 parents 6f753c8 + 7566f41 commit c0765fb
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions library/alloc/src/sync.rs
Original file line number Diff line number Diff line change
Expand Up @@ -197,11 +197,7 @@ macro_rules! acquire {
///
/// Sharing some immutable data between threads:
///
// Note that we **do not** run these tests here. The windows builders get super
// unhappy if a thread outlives the main thread and then exits at the same time
// (something deadlocks) so we just avoid this entirely by not running these
// tests.
/// ```no_run
/// ```
/// use std::sync::Arc;
/// use std::thread;
///
Expand All @@ -220,7 +216,7 @@ macro_rules! acquire {
///
/// [`AtomicUsize`]: core::sync::atomic::AtomicUsize "sync::atomic::AtomicUsize"
///
/// ```no_run
/// ```
/// use std::sync::Arc;
/// use std::sync::atomic::{AtomicUsize, Ordering};
/// use std::thread;
Expand Down

0 comments on commit c0765fb

Please sign in to comment.