fix: symbol.hasInstance needed to be static #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 This PR is included in version 4.0.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
| @@ -18,7 +18,7 @@ export const FormData = class FormData { | |||
| constructor(...a){if(a.length)throw new TypeError(`Failed to construct 'FormData': parameter 1 is not of type 'HTMLFormElement'.`)} | |||
| get [t]() {return 'FormData'} | |||
| [i](){return this.entries()} | |||
| [h](o) {return typeof o==='object'&&o[t]==='FormData'&&!m.some(m=>typeof o[m]!='function')} | |||
| static [h](o) {return typeof o==='object'&&o[t]==='FormData'&&!m.some(m=>typeof o[m]!='function')} | |||
There was a problem hiding this comment.
typeof object === "object" && object[Symbol.toStringTag] === "FormData"This assertion will cause an error when object is null, same issue as node-fetch/fetch-blob#58
I also think that you'll better check at least some methods existence. I think these assertions would be more than enough: https://github.com/octet-stream/form-data-encoder/blob/a94e5e4c37304334349b902d094048e380ff6ab2/lib/util/isFormData.ts#L10-L18
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is:
... the symbol.hasInstance didn't work cuz it wasn't static
BodyMixin.formData()and constructing bodies with FormData node-fetch/node-fetch#1314 (review)