Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hangs process in Node.js #6

Open
jcbhmr opened this issue Jul 7, 2023 · 1 comment
Open

Hangs process in Node.js #6

jcbhmr opened this issue Jul 7, 2023 · 1 comment

Comments

@jcbhmr
Copy link
Contributor

jcbhmr commented Jul 7, 2023

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch await-sync@1.0.1 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/await-sync/mod.js b/node_modules/await-sync/mod.js
index 7bb40b0..e13b25a 100644
--- a/node_modules/await-sync/mod.js
+++ b/node_modules/await-sync/mod.js
@@ -20,6 +20,8 @@ function createWorker (signal) {
   return function awaitSync (fn, formatter) {
     const source = 'export default ' + fn.toString()
     const mc = new MessageChannel()
+    mc.port1.unref?.()
+    mc.port2.unref?.()
     const localPort = mc.port1
     const remotePort = mc.port2
     worker.postMessage({ port: remotePort, code: source, ab }, [remotePort])

This issue body was partially generated by patch-package.

@jcbhmr
Copy link
Contributor Author

jcbhmr commented Jul 7, 2023

This is a thing in v1.0.1. I assume it carries over to v1.0.2 since the update doesn't touch it at all? Can't verify without #7 fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant