Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency problem with Tinycolor2 #714

Closed
onokje opened this issue Mar 29, 2019 · 3 comments · Fixed by #1187
Closed

Dependency problem with Tinycolor2 #714

onokje opened this issue Mar 29, 2019 · 3 comments · Fixed by #1187
Labels
bug there is a bug in the way jimp behaves released This issue/pull request has been released.

Comments

@onokje
Copy link

onokje commented Mar 29, 2019

Expected Behavior

Dependencies don't have any problems

Current Behavior

Dependency "tinycolor2" has a security vulnerability, because it includes an old jquery version, that in term has a known vulnerability.

Failure Information (for bugs)

I know technically this is not a bug, but i still hope i can be fixed, we now have to use path-package to fix our project, and I hate doing that.
https://github.com/TypeCtrl/tinycolor can probably used, as it is tinycolor2's successor.

Steps to Reproduce

  1. install
  2. run secutiry checker (we use https://retirejs.github.io/retire.js/)
  3. error shows problem in tinycolor2

Context

  • Jimp Version: any
  • Operating System: ubuntu
  • Node version: 8.12

Failure Logs

Found project in /tmp/app
+----------------------------------------------------------------------------------------+
| Severity | Tool | Identifier |
+----------------------------------------------------------------------------------------+
| Medium | Retire.js | CVE-2015-9251 |
| |
| 3rd party CORS request may execute in jquery |
| In node_modules/tinycolor2/demo/jquery-1.9.1.js |
+----------------------------------------------------------------------------------------+

@hipstersmoothie
Copy link
Collaborator

Down to change to an updated version. Feel free to make a PR! The example uses jquery but not the library itself so this seems like a false alarm to me. jquery isn't even listed as any type of dependency

@hipstersmoothie hipstersmoothie added the bug there is a bug in the way jimp behaves label Sep 3, 2019
@terrynguyen255
Copy link

+1

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

🚀 Issue was released in v0.22.4 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug there is a bug in the way jimp behaves released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants