Skip to content

Commit fe24690

Browse files
alambalamb
authored
Add comments to Cargo.toml about workspace overrides (apache#18526)
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> - Follow on to apache#18468 ## Rationale for this change We missed the fact that you couldn't yet add new linter rules to subcrates via Cargo.toml overrides. Thankfully @Jefffrey sorted is out. Let's try and avoid that again by leaving a comment ## What changes are included in this PR? Add comments to help our future selves remember to add new lints to lib.rs rather than Cargo.toml for subcrates ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. -->
1 parent 3b4bcca commit fe24690

File tree

41 files changed

+123
-0
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

41 files changed

+123
-0
lines changed

‎benchmarks/Cargo.toml‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,9 @@ repository = { workspace = true }
2626
license = { workspace = true }
2727
rust-version = { workspace = true }
2828

29+
# Note: add additional linter rules in lib.rs.
30+
# Rust does not support workspace + new linter rules in subcrates yet
31+
# https://github.com/rust-lang/cargo/issues/13157
2932
[lints]
3033
workspace = true
3134

‎datafusion-examples/Cargo.toml‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,9 @@ license = { workspace = true }
2929
authors = { workspace = true }
3030
rust-version = { workspace = true }
3131

32+
# Note: add additional linter rules in lib.rs.
33+
# Rust does not support workspace + new linter rules in subcrates yet
34+
# https://github.com/rust-lang/cargo/issues/13157
3235
[lints]
3336
workspace = true
3437

‎datafusion/catalog-listing/Cargo.toml‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,9 @@ tokio = { workspace = true }
5151
[dev-dependencies]
5252
datafusion-datasource-parquet = { workspace = true }
5353

54+
# Note: add additional linter rules in lib.rs.
55+
# Rust does not support workspace + new linter rules in subcrates yet
56+
# https://github.com/rust-lang/cargo/issues/13157
5457
[lints]
5558
workspace = true
5659

‎datafusion/catalog/Cargo.toml‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,5 +49,8 @@ object_store = { workspace = true }
4949
parking_lot = { workspace = true }
5050
tokio = { workspace = true }
5151

52+
# Note: add additional linter rules in lib.rs.
53+
# Rust does not support workspace + new linter rules in subcrates yet
54+
# https://github.com/rust-lang/cargo/issues/13157
5255
[lints]
5356
workspace = true

‎datafusion/common-runtime/Cargo.toml‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,9 @@ rust-version = { workspace = true }
3131
[package.metadata.docs.rs]
3232
all-features = true
3333

34+
# Note: add additional linter rules in lib.rs.
35+
# Rust does not support workspace + new linter rules in subcrates yet
36+
# https://github.com/rust-lang/cargo/issues/13157
3437
[lints]
3538
workspace = true
3639

‎datafusion/common/Cargo.toml‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,9 @@ rust-version = { workspace = true }
3131
[package.metadata.docs.rs]
3232
all-features = true
3333

34+
# Note: add additional linter rules in lib.rs.
35+
# Rust does not support workspace + new linter rules in subcrates yet
36+
# https://github.com/rust-lang/cargo/issues/13157
3437
[lints]
3538
workspace = true
3639

‎datafusion/core/Cargo.toml‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,9 @@ rust-version = { workspace = true }
3232
[package.metadata.docs.rs]
3333
all-features = true
3434

35+
# Note: add additional linter rules in lib.rs.
36+
# Rust does not support workspace + new linter rules in subcrates yet
37+
# https://github.com/rust-lang/cargo/issues/13157
3538
[lints]
3639
workspace = true
3740

‎datafusion/datasource-arrow/Cargo.toml‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,9 @@ tokio = { workspace = true }
5151
[dev-dependencies]
5252
chrono = { workspace = true }
5353

54+
# Note: add additional linter rules in lib.rs.
55+
# Rust does not support workspace + new linter rules in subcrates yet
56+
# https://github.com/rust-lang/cargo/issues/13157
5457
[lints]
5558
workspace = true
5659

‎datafusion/datasource-avro/Cargo.toml‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,9 @@ object_store = { workspace = true }
4747
[dev-dependencies]
4848
serde_json = { workspace = true }
4949

50+
# Note: add additional linter rules in lib.rs.
51+
# Rust does not support workspace + new linter rules in subcrates yet
52+
# https://github.com/rust-lang/cargo/issues/13157
5053
[lints]
5154
workspace = true
5255

‎datafusion/datasource-csv/Cargo.toml‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,9 @@ object_store = { workspace = true }
4747
regex = { workspace = true }
4848
tokio = { workspace = true }
4949

50+
# Note: add additional linter rules in lib.rs.
51+
# Rust does not support workspace + new linter rules in subcrates yet
52+
# https://github.com/rust-lang/cargo/issues/13157
5053
[lints]
5154
workspace = true
5255

0 commit comments

Comments
 (0)