Jasmine2 support

[PaddyMann]

We've happily been using this plugin but it has stopped working since changing Protractor to use jasmine2.

Is jasmine2 support planned?

[mping]

I've forked and hacked it, here's the relevant commit: mping@8b1bd69

I also made slight changes to suit my needs, but as soon as the maintainer supports jasmine2 I'm gonna go back to this repo.

For reference, here are the hooks on jasmine 2:

var currentSuite, currentSpec;
ScreenshotReporter.prototype.jasmineStarted = function () {
    //console.log("##test[progressStart 'Running Jasmine Tests']");
};

ScreenshotReporter.prototype.jasmineDone = function () {
    //console.log("##test[progressFinish 'Running Jasmine Tests']");
};

ScreenshotReporter.prototype.suiteStarted = function (suite) {
    currentSuite = suite;
    //console.log("##START[testSuiteStarted name='" + (suite.fullName) + "']");
};

ScreenshotReporter.prototype.suiteDone = function (suite) {
    //console.log("##test[testSuiteFinished name='" + (suite.fullName) + "']");
};

ScreenshotReporter.prototype.specStarted = function (spec) {
    currentSpec = spec;
    //console.log("##START[testStarted name='" + (spec.description) + "' captureStandardOutput='true']");
};

ScreenshotReporter.prototype.specDone = function (spec) {

[cindoum]

Waiting for this to be fixed, thanks to @mping for your fork!

[jdann]

Is there any update on when/if this will be released?

[avnersorek]

+1

[jintoppy]

@jdann, @avnersorek , @cindoum : Sorry for the delayed response. Right now I am tied up with my work. Not getting time to spend on this. I see a similar one for jasmine2. Please check it out.
Jasmine2 Reporter

[avnersorek]

Thanks, I've moved to mping's fork - https://github.com/mping/protractor-html-screenshot-reporter

[sentient]

To use the fork replace in your file package.json

  "protractor-html-screenshot-reporter": "mping/protractor-html-screenshot-reporter"

 >  npm update protractor-html-screenshot-reporter

[sentient]

I think it is runnning into the issue of angular/protractor#1938
I am running a standalone chrome driver. The first request to take a screenshot takes some time, and that stops the flow. Maybe good to fist update the metaData, and then see if you success in taking a screenshot

[eddiemonge]

@mping have you submitted a pull request to merge in your changes?

[toupeira]

@mping's fork worked for me as well, but it's already lagging behind upstream with some other fixes I would like :) I'll glady submit a PR if nobody else wants to...

[toupeira]

..and in the meantime I switched to https://github.com/mlison/protractor-jasmine2-screenshot-reporter which Works For Me™.

[mping]

@eddiemonge I don't have alot of time, just submitted a crappy PR: #69

@toupeira feel free to do a better job, I know at least should have squashed but my code was really old.

[chaitanyakatta]

@mping I used your fork for Jasmine2 to test out I ran a suite with 2 tests (it blocks) it is displaying the report only for one.

[hypery2k]

any news on this PR?