Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No support for submodules #290

Closed
oferei opened this issue Jul 13, 2016 · 8 comments
Closed

No support for submodules #290

oferei opened this issue Jul 13, 2016 · 8 comments

Comments

@oferei
Copy link

oferei commented Jul 13, 2016

I have a git submodule within my git project. When I open a submodule file in Sublime I see plus signs beside all the lines, as if the entire content is newly added.

@oferei
Copy link
Author

oferei commented Jul 13, 2016

and thanks for this plugin! ^__^

@rchl
Copy link
Collaborator

rchl commented Nov 13, 2016

I'm working with submodule on a daily basis and it works for me.

I assume that if you manually navigate to the submodule's directory and invoke git diff then you don't see those being shown as added? If so, is it possible that GitGutter is using different installation of git than your terminal and one of them has this problem? I've seen issues with submodule support in various apps depending on used git (for example msysgit versus cygwin).

Please at least state your OS and git version.

@oferei
Copy link
Author

oferei commented Nov 17, 2016

You assume right - git diff shows no differences.
I'm using macOS Sierra (v10.12.1) and git version 2.9.3 (Apple Git-75).

@rchl
Copy link
Collaborator

rchl commented Nov 17, 2016

Is it reproducible for you on any public repo, so that I could try it locally? It works with the submodule for me in my repo.
Tried using both git 2.9.1 and git 2.7.4 (Apple Git-66).

@oferei
Copy link
Author

oferei commented Nov 20, 2016

Created brand new projects, both on GitHub and BitBucket, but could not reproduce - worked as expected. So it's some problem with my repo.

@deathaxe
Copy link
Collaborator

This issue may be caused by some versions of git itself. Some git commands randomly fail, if git is not called from within the working tree, but this is exactly what GitGutter does.

I prepared a fix to run all git commands from within the working tree, which is published as soon as all required PRs are accepted.

@deathaxe
Copy link
Collaborator

deathaxe commented Mar 6, 2017

Should work with GitGutter 1.5.0. Same as with work-tree support. Please check.

@oferei
Copy link
Author

oferei commented Mar 7, 2017

It works with 1.5.0! (^O^)/

@deathaxe deathaxe closed this as completed Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants