Tests for handling unknown/stale ADS notifications failing with AdsRouterConsole #165
Labels
bug
Something isn't working
Comments
|
Hmm, this is odd. Are the tests under ads-client/test/TC3/ads-client.test.js Line 3595 in 51702a2 Could you also set the debugging level to 2 and paste the logs. |
|
@crishoj I just got the same issue and the reason was that Autostart boot project was not checked. Can you check that? |
|
Just made sure Autostart boot project is checked: 
Still getting two failing tests: 
And the test hangs at the end with this message (from 
|
In the following, I removed most other tests in order to reduce the log volume. Debug output |
|
Hmm, this is a strange issue. Perhaps it's because of the The test is currently also doing the reconnect immediately: // Forcefully disconnect, without unsubscribing
await client2.disconnect(true);
await client2.connect();See +1ms: That could one option as well. We could try to wait ~1s to see if it helps with await client2.disconnect(true);
await delay(1000);
await client2.connect();I need to setup the AdsRouterConsole to test this out. |
|
I configured AdsRouterConsole and managed to reproduce the same error. So it's definetely related to the router implementation. I'm used PC<->PC connection instead of Mac. Delay isn't helping either. If changing the ADS port in between, the connection works. However the tests obviously not, but this tells us that the router doesn't like using the same port immediately again await client2.disconnect(true);
client2.settings.localAdsPort = 33000;
await client2.connect();By looking at the router debug data, we can see the port is still reserved. We probably need to double check if ads-client could handle that To be continued.. |
jisotalo
changed the title
|
I tested with the updated Maybe we are just doing things that shouldn't be done. However that test is quite good. I'm open to any ideas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Running
test/TC3/ads-client.test.jsagainst my PC-based TC3 4024.62, all tests are passing, except the tests related to handling unknown/stale ADS notifications.The problem appears to be connecting the auxiliary client:
I wonder what prevents the second client from connecting. I am using connection setup 2, with ads-client +
AdsRouterConsoleon my Mac, connecting to TC on a Windows PC.Any idea what's preventing the second client from connecting?
The text was updated successfully, but these errors were encountered: