CI/Build Issue

[DanielMcAssey]

Just had a look at the latest .tar.gz after the fixes for the types, it looks like the index.d.ts did not get re-generated, or its cached?

Also the types/auto directory is still there.

Specifically this version: https://github.com/jitsi/lib-jitsi-meet/releases/tag/v1745.0.0%2B47fc0fbb

[DanielMcAssey]

Just had a look, need a few more changes to the type generation, theres an issue with inferring types.

Not sure why the auto directory is still there though

[DanielMcAssey]

Issue with typescript on generating types that override the constructor, microsoft/TypeScript#53266

[DanielMcAssey]

@saghul seems to fix the constructor typescript generate problem, we need to upgrade typescript 1 major version to at least 5.1.3 (The first version to include that fix). Ideally to the latest 5.3.3, am I okay to create a PR that does this?

For reference this is the last outstanding issue:

Error: node_modules/lib-jitsi-meet/index.d.ts:3120:20 - error TS1005: '(' expected.

3120         constructor: typeof JitsiTrackError;
                        ~


Error: node_modules/lib-jitsi-meet/index.d.ts:13842:20 - error TS1005: '(' expected.

13842         constructor: typeof JitsiConference;
                         ~

Because of:

lib-jitsi-meet/JitsiConference.js

Line 328 in 47fc0fb

JitsiConference.prototype.constructor = JitsiConference;

and

lib-jitsi-meet/JitsiTrackError.js

Line 139 in 47fc0fb

JitsiTrackError.prototype.constructor = JitsiTrackError;

[saghul]

Just had a look at the latest .tar.gz after the fixes for the types, it looks like the index.d.ts did not get re-generated, or its cached?

We use a prepare script:

lib-jitsi-meet/package.json

Line 76 in 47fc0fb

"prepack": "npm run build && npm run gen-types",

I wonder if we need to delete the file before running it?

Also the types/auto directory is still there.

That must be because we don't clean the directory. @damencho Can we perhaps add a git clean -dfx before we start the build process? I forgot where that script is.

[saghul]

am I okay to create a PR that does this?

Absolutely!

[damencho]

That must be because we don't clean the directory. @damencho Can we perhaps add a git clean -dfx before we start the build process? I forgot where that script

On ci, there is a build job.

[damencho]

Let's extract whatever we can from there and add it as a script here, the way we have it already for jibri and jvb.

[saghul]

Not sure I follow.

[damencho]

Have these here
https://github.com/jitsi/jibri/blob/master/resources/jenkins/build.sh

https://github.com/jitsi/jibri/blob/master/resources/jenkins/release.sh

So we can control scripts from the source code and not from jenkins job.

[damencho]

We have similar for jvb
https://github.com/jitsi/jitsi-videobridge/tree/master/resources/jenkins

We have been doing that for every project that we move to the new version with the git hash, that is the plan and for jitsi-meet for the last 5 years :) One day ...